Review for Source Package: libebur128
[Summary]
MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.
This does need a security review, so I'll assign ubuntu-security
List of specific binary packages to be promoted to main: libebur128-1
libebur128-dev
Specific binary packages built, but NOT to be promoted to main: <none>
Required TODOs:
- #1 This suggested another team to own it, please can I have a debcraft
authority to agree to this here on the bug?
- #2 thanks for self identifying the lack of testing, please get
build time tests implemented in bug 2117702.
It has not many dependencies, so here an autopkgtest isn't strictly
necessary IMHO.
I'll assign it to Seb to decide if/how you want to go forward on this.
Debcrafters and subscriber and you to continue the work here?
If yes, please assign ubuntu-security as next we need their input as well.
[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality.
Some things around related replay gain and an ebu meter, but no lib
with the same function.
A team is committed to own long term maintenance of this package => Debcrafters
But they did not say yes to this, so let us ask them - required task.
The rationale given in the report seems valid and useful for Ubuntu especially
in the light of access and protection rules this can be useful.
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- no -dev/-debug/-doc packages that need exclusion (the one it has is fine)
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not expose any external endpoint (port/socket/... or similar)
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...)
- being the lib this isn't the place for usual risk mitigation features, in
this case that would be pipewire
Problems:
- does parse data formats (audio) from an untrusted source.
- does process arbitrary web content (as audio flowing through pulse)
[Common blockers]
OK:
- does not FTBFS currently
- This does not need special HW for build or test
- no new python2 dependency
Problems:
- does not have a test suite that runs at build time
- does not have a non-trivial test suite that runs as autopkgtest
=> added to required tasks
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking is in place.
- debian/watch is present and looks ok
- Upstream update history is slow (4 years old), but on issues there still is
activity
- Debian/Ubuntu update history is slow matching upstream
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems: None
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?
Problems: None
** Changed in: libebur128 (Ubuntu)
Assignee: Christian Ehrhardt (paelzer) => Sebastien Bacher (seb128)
** Changed in: libebur128 (Ubuntu)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2118381
Title:
[MIR] libebur128
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libebur128/+bug/2118381/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
