Review for Source Package: dgx-desktop-sbsa-gwdt-loader
[Summary]
The dgx-desktop-sbsa-gwdt-loader package is a minimal, architecture-specific
utility for NVIDIA DGX systems. It provides a shell script and systemd service
that conditionally loads the sbsa_gwdt watchdog kernel module on supported
hardware, ensuring system stability. The package is simple, with no compiled
code, no embedded libraries, and no complex dependencies. There is a version
1.2 of this package in flight that provides systemd service autopkgtesting
though it is not necessary to block on that upload.
MIR team ACK.
This does not need a security review.
List of specific binary packages to be promoted to main:
dgx-desktop-sbsa-gwdt-loader
[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality.
A team is committed to own long term maintenance of this package - Partner
Engineering.
The rationale given in the report seems valid and useful for Ubuntu
[Dependencies]
OK:
- no other runtime Dependencies to MIR due to this
- no other build-time Dependencies with active code in the final binaries
to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
OK:
- not a go package, no extra constraints to consider in that regard
- No vendoring used, all Built-Using are in main
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root - this package runs a short shell script at
boot via systemd to check the system’s modalias string for the presence of
“NVIDIA_DGX_SPARK”. This script is very simple, readable, and only runs
privileged actions if the hardware matches.
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...)
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does seem to need special HW for build or test so it can't be
automatic at build or autopkgtest time. But as outlined
by the requester in [Quality assurance - testing] there:
- is hardware and a test plan or code - the MIR submitter described the
autopkgtest that is still in flight for this package (v1.2). This packages
requires specialized Nvidia hardware that the owning team has access to via
testflinger (nvidia-n1x-spark-prod).
- no new python2 dependency
Problems: None
[Packaging red flags]
OK:
- Ubuntu does not carry a delta (native package)
- symbols tracking not applicable for this kind of code.
- debian/watch is not present but also not needed (e.g. native)
- Upstream update history is N/A
- Debian/Ubuntu update history is good, though this is a very new package
- the current release is not packaged (1.1 versus 1.2 in provided PPA)
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems: None
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user 'nobody' outside of tests
(consider at least `grep -Hrn nobody` for it
and run `find . -user nobody` in source and built binaries)
- no use of setuid / setgid
(consider at least `grep -Hrn -e setuid -e setgid` for it
and run `find . \( -perm -4000 -o -perm -2000 \)` in source and
built binaries)
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case
Problems: None
** Changed in: dgx-desktop-sbsa-gwdt-loader (Ubuntu)
Status: New => In Progress
** Changed in: dgx-desktop-sbsa-gwdt-loader (Ubuntu)
Assignee: Myles Penner (mylesjp) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2136719
Title:
[MIR] dgx-desktop-sbsa-gwdt-loader
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dgx-desktop-sbsa-gwdt-loader/+bug/2136719/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
