Here is my initial review. I still have to go over debian/copyright in more detail, so that is excluded from my comments for now.
a) please update d/watch to pull in the correct tarball. Also take the opportunity to update it to v5 please. b) d/control is restricting build to amd64. We should make an effort to have it building in more architectures, specially because given upstream's Loopino/Makefile, ARM was supposed to be supported. Erich filed [1] about this. I believe the logic in checking cpu flags from /proc/cpuinfo in that makefile is just buggy. c) regardless of (b), amd64v3 should not be listed in Architectures d) Embedded library rubberband. This library exists in the archive already, and the project should be using that instead. If this is not possible, let's discuss. e) d/control descriptions: there are two whitespaces prepending the lines in the long descriptions, it should be just one. f) lintian is throwing some missing hardening warnings, could this be because the package is not following the flags set by dpkg-buildflags? I haven't investigated fully, but these are the warnings: W: loopino-standalone: hardening-no-relro [usr/bin/loopino] I: loopino-clap: hardening-no-bindnow [usr/lib/clap/loopino.clap] I: loopino-vst: hardening-no-bindnow [usr/lib/vst/loopinovst.so] 1. https://github.com/brummer10/Loopino/issues/12 ** Bug watch added: github.com/brummer10/Loopino/issues #12 https://github.com/brummer10/Loopino/issues/12 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2137383 Title: Packaged: loopino To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2137383/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
