+static void
+unlock_gnome_keyring (CcDesktopSharingPage *self)
+{
+  g_autoptr(SecretService) service = NULL;
+  g_autoptr(GList) collections_to_unlock = NULL;
+  g_autoptr(SecretCollection) collection = NULL;
+  g_autoptr(GError) error = NULL;
+
+  service = secret_service_get_sync (SECRET_SERVICE_LOAD_COLLECTIONS, NULL, 
&error);
+  if (!service)
+    {
+      g_debug ("Can't connect to secret service: %s", error->message);
+      return;
+    }
+
+  collection = secret_collection_for_alias_sync (service,
+                                                 SECRET_COLLECTION_DEFAULT,
+                                                 SECRET_COLLECTION_LOAD_ITEMS,
+                                                 NULL, &error);
+  if (!collection)
+    {
+      g_debug ("Can't load secret collection: %s", error->message);
+      return;
+    }
+

Doesn't this have the same logic error that is being fixed by
https://gitlab.gnome.org/GNOME/gnome-control-
center/-/commit/334c2a076e22295dbf46b7d1849e1ebb1f8d897d?

Related, are the `secret_service_get_*` calls guaranteed to set error to
non-NULL when returning NULL?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2000063

Title:
  RDP password is silently reset to a random passphrase if using
  autologin

To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-control-center/+bug/2000063/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to