Review for Source Package: uwsgi-plugin-python [Summary]
The package uwsgi-plugin-python3 needs to be in main to satisfy the runtime dependency of uwsgi for OpenStack services. This is a debian native package that contains only debian packaging; the actual sources are pulled during build from the uwsgi-src binary package, details in debian/README.source. A review of the uwsgi-src sources have been made as part of https://bugs.launchpad.net/ubuntu/+source/uwsgi/+bug/2151202 MIR. AFAICT the sources that are actually used to build the uwsgi-plugin-python3 from uwsgi source package are: - plugins/asyncio/* - plugins/python/* - uwsgidecorators.py MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs. This does not need a security review List of specific binary packages to be promoted to main: uwsgi-plugin-python3 Specific binary packages built, but NOT to be promoted to main: uwsgi-plugin-gevent, uwsgi-plugin-greenlet, uwsgi-plugin-tornado Notes: Required TODOs: 1. Companion uwsgi MIR to be promoted together: https://bugs.launchpad.net/ubuntu/+source/uwsgi/+bug/2151202 2. The package should get a team bug subscriber before being promoted [Rationale, Duplication and Ownership] There is no other package in main providing the same functionality. Openstack team is committed to own long term maintenance of this package. The rationale given in the report seems valid and useful for Ubuntu [Dependencies] OK: - no other runtime Dependencies to MIR due to this - no other build-time Dependencies with active code in the final binaries to MIR due to this - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: None [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have unexpected Built-Using entries - not a go package, no extra constraints to consider in that regard - not a rust package, no extra constraints to consider in that regard Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not parse data formats (files [images, video, audio, xml, json, asn.1], network packets, structures, ...) from an untrusted source. - does not expose any external endpoint (port/socket/... or similar) - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) - does not deal with cryptography (en-/decryption, certificates, signing, ...) - this makes appropriate (for its exposure) use of established risk mitigation features (dropping permissions, using temporary environments, restricted users/groups, seccomp, systemd isolation features, apparmor, ...) Problems: None [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - does have a non-trivial test suite that runs as autopkgtest - This does not need special HW for build or test - no new python2 dependency - Python package, but using dh_python Problems: None [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking not applicable for this kind of code because it the shared objects are only used internally and no headers made available. - debian/watch is not present but also not needed (e.g. native) - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - debian/rules is rather clean - It is not on the lto-disabled list Problems: None [Upstream red flags] OK: - no incautious use of malloc/sprintf (as far as we can check it) - the package is taking care of debian packaging, the sources are pulled from upstream - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user 'nobody' outside of tests - no use of setuid / setgid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit or libseed - not part of the UI for extra checks - no translation present, but none needed for this case (user visible)? Problems: - A couple of warnings during build -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2152614 Title: [MIR] uwsgi-plugin-python To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/uwsgi-plugin-python/+bug/2152614/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
