** Description changed: - [Impact] - fu_genesys_gl32xx_device_attach() and fu_genesys_gl32xx_device_detach() are cast to FuDeviceLockerFunc: + [ Impact ] + + fu_genesys_gl32xx_device_attach() and fu_genesys_gl32xx_device_detach() + are cast to FuDeviceLockerFunc: g_autoptr(FuDeviceLocker) locker = fu_device_locker_new_full(FU_DEVICE(self), (FuDeviceLockerFunc)fu_genesys_gl32xx_device_detach, (FuDeviceLockerFunc)fu_genesys_gl32xx_device_attach, error); FuDeviceLockerFunc expects two arguments, the device and an error output variable: typedef gboolean (*FuDeviceLockerFunc)(FuDevice *device, GError **error); The two functions however take three arguments: fu_genesys_gl32xx_device_attach(FuDevice *device, FuProgress *progress, GError **error) fu_genesys_gl32xx_device_setup(FuDevice *device, GError **error) The invalid cast seems to have been there since the introduction of the plugin, so the increased crash rate seems to be a co-incidence. - [Original bug report] + [ Test Plan ] + + After the aging and release of this SRU, the crashes on the error + tracker should go away for this issue. + + Additionally we expect the overall crash rate to be lower as well. + + [ Where problems could occur ] + + Updating this device has been causing crashes before (the code never + worked, the cast was always wrong). + + Thus there isn't any substantial regression potential from patching code + that never worked. + + [ Other Info ] + The Ubuntu Error Tracker has been receiving reports about a problem regarding fwupd. This problem was most recently seen with package version 2.1.1-1ubuntu3, the problem page at https://errors.ubuntu.com/problem/a18445bf797ed5c482a1d8a4b567863f7b2807ea contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports. If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2156612 Title: /usr/libexec/fwupd/fwupd:11:fu_udev_device_ioctl:fu_ioctl_execute:fu_block_device_sg_io_cmd_none:fu_genesys_gl32xx_device_cmd_reset_usb:fu_genesys_gl32xx_device_attach To manage notifications about this bug go to: https://bugs.launchpad.net/fwupd/+bug/2156612/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
