** Description changed:
[ Impact ]
Users running ROCm 7.1.0 on Resolute receive an outdated library that:
- has a memory-safety defect in printBuildInfo(): the two-step
getBuildInfoLen()+getBuildInfo() pattern did not handle malloc()
failure, risking a NULL-pointer dereference or undefined behaviour
when heap memory is exhausted.
- uses a misspelled public enum symbol (VerIncorrecPararmeters) that
makes source-level integration error-prone.
- is missing the #%Module header in rocmmod.in, breaking Lmod
environment-module support.
- does not ship the rdhc (ROCm Deployment Health Check) diagnostic
tool, which is now part of the upstream release.
This upload brings rocm-core to 7.2.4, the version shipped in the
coordinated ROCm 7.2.4 stack SRU. All fixes are upstream releases;
no Ubuntu-specific delta beyond the packaging.
[ Test Plan ]
1. Build
Package successfully builds in the bug PPA as well as the Bullwinkle
team rocm-devel PPA via recipe. Bullwinkle team has pushed the
package to Debian experimental and then synced it to stonking.
2. Install & basic smoke-test
sudo apt install librocm-core1 librocm-core-dev
# Verify reported version:
python3 -c "import ctypes; lib=ctypes.CDLL('librocm-core.so.1'); \
mj,mn,pt=ctypes.c_uint(),ctypes.c_uint(),ctypes.c_uint(); \
lib.getROCmVersion(ctypes.byref(mj),ctypes.byref(mn),ctypes.byref(pt)); \
print(mj.value, mn.value, pt.value)"
# Output: 7 2 4
3. Autopkgtest
- All autopkgtests pass (see Other Info) thus confirming instabillity again.
+ All autopkgtests pass (see Other Info)
[ Where problems could occur ]
- The VerErrors enum gained a new value (VerMemoryAllocationFailed)
inserted between VerIncorrectParameters and VerValuesNotDefined,
shifting the ordinal of VerValuesNotDefined from 2 to 3 and
VerErrorMAX from 3 to 4. Any consumer that compares VerErrors
values numerically (rather than by symbol name) would silently
misinterpret error codes. Symptom: unexpected "values not defined"
error paths or incorrect error-string mapping at runtime.
- The rdhc tool requires python3-prettytable and python3-yaml at
runtime. If those are absent the tool exits with a clear warning;
the library itself is unaffected. Symptom: running rdhc prints
"WARNING: Missing Required Python Packages" and exits 1.
- If the malloc() fix in printBuildInfo() introduced a regression,
callers that previously received VerSuccess on a system where
ROCM_BUILD_INFO is undefined would now receive VerValuesNotDefined.
Symptom: diagnostic tools reporting unexpected build-info errors.
[ Other Info ]
* ABI: SONAME unchanged (librocm-core.so.1).
abipkgdiff (full log: https://paste.ubuntu.com/p/g4fkPDgkg4/) confirms
no functions or variables removed. One indirect sub-type change in the
VerErrors enum returned by getROCmVersion():
- 'VerIncorrecPararmeters' (value 1) renamed to
'VerIncorrectParameters' (value 1) - typo fix.
- 'VerMemoryAllocationFailed' inserted at value 2.
- 'VerValuesNotDefined' shifted from value 2 → 3.
- 'VerErrorMAX' shifted from value 3 → 4.
rocm-core has no reverse-dependencies in resolute, so there is no
installed-package regression risk.
* This update is part of the coordinated ROCm 7.2.4 stack SRU.
* PPA: https://launchpad.net/~b0b0a/+archive/ubuntu/rocm-core-2153989
* Autopkgtest results:
https://autopkgtest.ubuntu.com/user/b0b0a/ppa/rocm-core-2153989
* Upstream comparison:
https://github.com/ROCm/rocm-core/compare/rocm-7.1.0...rocm-7.2.4
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2153989
Title:
SRU: New upstream version 7.2.4
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rocm-core/+bug/2153989/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
