Hey Alex, Thanks for the updates:
Versions look good; technically you could have used `1.10.0-1ubuntu0.1` for Noble but keeping them consistent this way is nice. You need to run update-maintainer (I missed this on my first pass; very sorry) [1]. In your "Where problems could occur" section, you say "However, this hypothetical depends on OTHER privileged programs behaving incorrectly, which is not the responsibility of virtiofsd." This is true, but as a stable distribution we are responsible for ensuring that we don't regress other programs in general [2][3]. For this section, almost every SRU is making the argument that regressions are unlikely; we're more concerned with what the impact might be if there is a regression and how that might manifest to a user. For example, I worked on a case where the "Where problems could occur" section from LP: #2101903 described the _exact_ circumstances under which the user was operating; in that case, it was clear from the LP bug what needed to change in their environment. This SRU won't have the same straightforward configuration impact, but its worth asking what a regression-affected user might want to read in your template. I recommend working sru-lint and/or ubuntu-lint into your workflow; they will catch a whole bunch of gotchas (update-maintainer, etc) that are easy to miss. Clearly I need to do this as well :) [1] https://ubuntu.com/project/docs/how-ubuntu-is-made/concepts/debian-maintainer/#debian-maintainer [2] https://ubuntu.com/project/docs/SRU/explanation/principles/#minimise-regression [3] https://ubuntu.com/project/docs/SRU/explanation/requirements/#public-documentation [4] https://bugs.launchpad.net/ubuntu/+source/edk2/+bug/2101903 [5] https://github.com/canonical/sru-lint/ [6] https://github.com/ubuntu/ubuntu-lint -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2155048 Title: [SRU] Backport request - server: do not reject oversized readdir requests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/rust-virtiofsd/+bug/2155048/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
