@enr0n thank you for the feedback. I provided an explanation below

1. I will use the example of noble in terms of version strings here. The MINVER 
is not "GNUTLS_3_8_2" but it is "3.8.3-1.1ubuntu3.6".

The version string "GNUTLS_3_8_2" represents the symbol versioning used
by libgnutls and in this case it is "GNUTLS_3_8_2" because I have added
the new function inside the "GNUTLS_3_8_2" section in
"gnutls28-3.8.3/lib/libgnutls.map" which is the newest entry.

The actual MINVER is "3.8.3-1.1ubuntu3.6" which is wrong and I should
have updated it to "3.8.3-1.1ubuntu3.7" after bumping up the changelog
but I forgot to.

The reason the library version is $(upstream - 1) is because the
$(upstream) version did not add any new APIs so no new entry was created
for it. When I wrote this patch to gnutls upstream I did add a new entry
since it makes sense for a new upstream release
(https://gitlab.com/gnutls/gnutls/-/merge_requests/2074/diffs?file_path=lib%2Flibgnutls.map#7e6754d1f3720abd08e5a81ace7d7771e5a100d2).
For Ubuntu I decided to just append it to the latest upstream release
that expanded the API.


2. I can remove the entry from the symbols file and rename and move the
function around so that p11tool has access to it. However this would
deviate from upstream. If you are okay with this I can do it. However
the current implementation does work just fine and exposes the API to
anyone who would want to use it. If you think its better to keep the new
function exposes to the API to stay closer to upstream, I will need to
bump the MINVER to sync it with the changelog bump.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2150202

Title:
  p11tool returns duplicate entries when pkcs URIs are the same for
  multiple pkcs11 objects

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnutls28/+bug/2150202/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to