Public bug reported:

SRU Justification

[Impact]

Previously, the maximum queue depth supported for gVNIC on overcommitted Gen3+ 
VMs
(such as N4) was increased from 1K to 4K in the GCP kernel using the patchset 
titled
"Support larger gVNIC queue depth on Gen3+ GCE VMs". However, the upstream 
commit
5e37d8254e7f ("gve: Add header split data path") has two additional bug-fix 
commits.
This patchset targets and applies those two specific fixes.

[Fix]

Noble (6.8) and Jammy (5.15)
d676c9a73bdc ("gve: fix header buffer corruption with header-split and HW-GRO")
6bf14575c655 ("gve: fix zero-length skb frag with header-split")

Resolute (7.0)

6bf14575c655 ("gve: fix zero-length skb frag with header-split")

[Test Plan]

* Compile Tested
* Boot Tested
* The following output indicates the feature is missing:
    $ sudo ethtool -G enp0s0 rx 4096
    netlink error: Operation not supported
  So the test plan for Canonical was to confirm that `sudo ethtool -G enp0s0 rx
  4096` exits successfully without an error.
* As well as this command, it should return 4096 as max no 1024:
  ethtool -g enp0s0

[Regression potential]

Regressions should only be possible when using the gVNIC device for
networking (which depends on the gve driver), and could most likely result in
networking failures on those configurations.

[Other]

SF: 00433236 (for GCP variants)
PIT: 509371317 (for GKE variants)

** Affects: linux-gcp (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: linux-gcp (Ubuntu Jammy)
     Importance: Undecided
     Assignee: Rickey Castillo Valenzuela (rickeycv)
         Status: In Progress

** Affects: linux-gcp (Ubuntu Noble)
     Importance: Undecided
     Assignee: Rickey Castillo Valenzuela (rickeycv)
         Status: In Progress

** Affects: linux-gcp (Ubuntu Resolute)
     Importance: Undecided
     Assignee: Rickey Castillo Valenzuela (rickeycv)
         Status: In Progress

** Also affects: linux-gcp (Ubuntu Resolute)
   Importance: Undecided
       Status: New

** Also affects: linux-gcp (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Also affects: linux-gcp (Ubuntu Jammy)
   Importance: Undecided
       Status: New

** Changed in: linux-gcp (Ubuntu Jammy)
     Assignee: (unassigned) => Rickey Castillo Valenzuela (rickeycv)

** Changed in: linux-gcp (Ubuntu Noble)
     Assignee: (unassigned) => Rickey Castillo Valenzuela (rickeycv)

** Changed in: linux-gcp (Ubuntu Resolute)
     Assignee: (unassigned) => Rickey Castillo Valenzuela (rickeycv)

** Changed in: linux-gcp (Ubuntu Jammy)
       Status: New => In Progress

** Changed in: linux-gcp (Ubuntu Noble)
       Status: New => In Progress

** Changed in: linux-gcp (Ubuntu Resolute)
       Status: New => In Progress

** Description changed:

  SRU Justification
  
  [Impact]
  
- Previously, the maximum queue depth supported for gVNIC on overcommitted 
Gen3+ VMs 
- (such as N4) was increased from 1K to 4K in the GCP kernel using the patchset 
titled 
- "Support larger gVNIC queue depth on Gen3+ GCE VMs". However, the upstream 
commit 
- 5e37d8254e7f ("gve: Add header split data path") has two additional bug-fix 
commits. 
+ Previously, the maximum queue depth supported for gVNIC on overcommitted 
Gen3+ VMs
+ (such as N4) was increased from 1K to 4K in the GCP kernel using the patchset 
titled
+ "Support larger gVNIC queue depth on Gen3+ GCE VMs". However, the upstream 
commit
+ 5e37d8254e7f ("gve: Add header split data path") has two additional bug-fix 
commits.
  This patchset targets and applies those two specific fixes.
  
  [Fix]
  
  Noble (6.8) and Jammy (5.15)
  d676c9a73bdc ("gve: fix header buffer corruption with header-split and 
HW-GRO")
  6bf14575c655 ("gve: fix zero-length skb frag with header-split")
  
  Resolute (7.0)
  
  6bf14575c655 ("gve: fix zero-length skb frag with header-split")
  
  [Test Plan]
  
  * Compile Tested
  * Boot Tested
  * The following output indicates the feature is missing:
-     $ sudo ethtool -G ens3 rx 4096
-     netlink error: Operation not supported
-   So the test plan for Canonical was to confirm that `sudo ethtool -G enp0s0 
rx
-   4096` exits successfully without an error.
+     $ sudo ethtool -G enp0s0 rx 4096
+     netlink error: Operation not supported
+   So the test plan for Canonical was to confirm that `sudo ethtool -G enp0s0 
rx
+   4096` exits successfully without an error.
  * As well as this command, it should return 4096 as max no 1024:
-   ethtool -g enp0s0
+   ethtool -g enp0s0
  
  [Regression potential]
  
- Regressions should only be possible when using the gVNIC device for 
- networking (which depends on the gve driver), and could most likely result in 
+ Regressions should only be possible when using the gVNIC device for
+ networking (which depends on the gve driver), and could most likely result in
  networking failures on those configurations.
  
  [Other]
  
  SF: 00433236 (for GCP variants)
  PIT: 509371317 (for GKE variants)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2167032

Title:
  Apply fixes for gve header split data path

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-gcp/+bug/2167032/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to