** Description changed:
+ [Impact]
+
Ubuntu repacks the ceph upstream tarball via `Files-Excluded:`, but
`debian/watch` sets no `repacksuffix` and the version carries no `+dfsg`/`+ds`
marker. A repacked orig and a pristine orig are therefore indistinguishable by
- version, and the only visible difference is the file extension (gz vs xz).
+ version, and even share the same file extension of .xz.
This causes confusion when someone ships a new upstream version.
- If `uscan` could add a suffix, uploaders/sponsors could have a hint on which
source is being used.
+ If `uscan` could add a suffix, uploaders/sponsors could have a hint on which
+ source is being used.
- The lack of a suffix has caused at least one incorrect upload to stonking,
where the pristine tarball from upstream was used instead of the repacked one:
https://launchpad.net/ubuntu/+source/ceph/20.2.1-0ubuntu1
- (yes it was me, I'm sorry).
+ The lack of a suffix has caused at least one incorrect upload to stonking,
+ where the pristine tarball from upstream was used instead of the repacked one:
+ https://launchpad.net/ubuntu/+source/ceph/20.2.1-0ubuntu1
- We could:
+ In ceph 20.2.4, we will:
1. Move `debian/watch` to `version=4`.
- 2. Add `repacksuffix=+dfsg` (or `+ds`) and fix `dversionmangle` to match.
- 3. Document in `debian/README.source` that the orig is repacked and that
- `uscan` must be used (not a manual download from download.ceph.com).
- 4. (not in packaging but worth it) update internal Ceph team docs to refer to
this, so backports are smoother.
+ 2. Add `repacksuffix=+ds` and fix `dversionmangle` to match.
+ 3. Change the version string to include `+ds`.
+
+ [Test case]
+
+ Ensure that the package version now contains `+ds` in the version string,
+ directly after the upstream version. Such as: 20.2.4+ds-0ubuntu1.
+
+ Ensure the .orig.tar.xz tarball is named appropriately:
+ ceph_20.2.4+ds.orig.tar.xz
+
+ When extracted, the source directory should be named: ceph-20.2.4+ds/
+
+ Ensure deployment charms are unaffected by including `+ds` in the
+ version string.
+
+ [Where problems can occur]
+
+ If a deployment script, or charm, or people's scripts that call dpkg -l don't
+ agree with the `+ds` in the package version, they may struggle to parse the
+ new version and have issues.
+
+ Debian has been using `+ds` for some time now, so we will align with
+ them.
** Changed in: ceph (Ubuntu Resolute)
Assignee: (unassigned) => Matthew Ruffell (mruffell)
** Changed in: ceph (Ubuntu Stonking)
Assignee: (unassigned) => Matthew Ruffell (mruffell)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2165173
Title:
the DFSG repack is invisible: no repacksuffix in d/watch
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/2165173/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
