Thanks for the heads up Christian. I addressed the phrasing once more,
but likely would've missed the bug status.

** Description changed:

  [Availability]
  - The package libssc is already in Ubuntu universe.
  - It currently builds and works for architectures: amd64, arm64, armhf. Link 
to package
    https://launchpad.net/ubuntu/+source/libssc
  - Building has been restricted to these architectures by Debian.
  
  [Rationale]
  - The package libssc is required in Ubuntu main for depends fulfillment in
    iio-sensor-proxy, to enable the SSC backend present since iio-sensor-proxy
    3.9 on Qualcomm ARM platforms.
  - We are working with Qualcomm boards and try to get Ubuntu working on 
Qualcomm
    machines.
- - Enabling this on Qualcomm machines is relevant for enabling Ubuntu on ARM
-   machines in the coming years.
+ - Qualcomm powers a large share of ARM-based phones and dev boards, so 
enabling
+   sensor support on these devices extends the reach of Ubuntu directly.
  - Package libssc covers the same use case as sensinghub, but is better because
    it is already integrated within iio-sensor-proxy and only a small targeted
    library as opposed to sensorhub.
  - The package libssc is a new runtime dependency of package iio-sensor-proxy
-   that we already support. The SSC backend has been disabled for the time 
being
-   due to libssc not being present in main. However this was a stopgap
-   measurement to avoid hasty decisions.
+   that we already support in main. Currently the SSC backend has been disabled
+   by enr0n. This was done to unblock iio-sensor-proxy for the stonking 
release.
+   The libssc package is a new addition we inherited from Debian and is not in
+   main (hence the MIR) to re-enable the SSC backend for iio-sensor-proxy.
  - This is the first time package will be in main
  - The binary packages libssc2 need to be in main to achieve the
    iio-sensor-proxy depends fulfillment and make these sensors accessible using
    that way.
  - It would be great and useful to community/processes to have the package
    libssc2 in Ubuntu main, but there is no definitive deadline.
  
  [Security]
  - No CVEs/security issues in this software in the past
  - no executables in `/sbin` and `/usr/sbin`
  - Package does not install services, timers or recurring jobs
  - Security has been kept in mind and common isolation/risk-mitigation patterns
    are in place utilizing the following features:
    - Transport: libssc communicates with the SSC service over the kernel
      AF_QIPCRTR socket family (via libqrtr-glib/libqmi-glib). There is no
      default OS-level access control. iio-sensor-proxy, mitigates this only at
      the via systemd RestrictAddressFamilies=...AF_QIPCRTR.
    - Systemd unit restricts socket family
    - Packages does not contain extensions to security-sensitive software
      (filters, scanners, plugins, UI skins, ...)
  
  [Quality assurance - function/usage]
  - The package works well right after install.
- - The MIR target is a library and a needs to be enabled in the 
iio-sensor-proxy
+ - The MIR target is a library and also needs to be enabled in the 
iio-sensor-proxy
    build process.
  
  [Quality assurance - maintenance]
  - The package has important open bugs, listing them:
    - https://codeberg.org/DylanVanAssche/libssc/issues/125 - crashing
-     iio-sensor-proxy
-   - https://codeberg.org/DylanVanAssche/libssc/issues/120 - crashing DSPs
-   - https://codeberg.org/DylanVanAssche/libssc/issues/111 - device specific
+     iio-sensor-proxy. Upstream rated this as a race condition, but no further
+     progress as of the time of writing.
+   - https://codeberg.org/DylanVanAssche/libssc/issues/120 - Upstream reacted
+     and says that this looks like a DSP error resulting in a I2C error which 
is
+     not gracefully handled by libssc yet.
+   - https://codeberg.org/DylanVanAssche/libssc/issues/111 - This is rated as a
+     device specific (onePlus 6T) issue.
  - The package does deal with niche hardware for the moment, such as primarily
-   dev boards. Such hardware is available to the team for debugging, test,
-   verification and development via:
+   dev boards or phones. Such hardware is available to the team for debugging,
+   test, verification and development via:
     - testflinger under the following queue(s):
       https://certification.canonical.com/platforms/14801/
  
  [Quality assurance - testing]
  - The package runs an autopkgtest, albeit superficial ones.
- - The package does have not failing autopkgtests right now.
- - The package has build time tests.
+ - The package does not have failing autopkgtests right now.
+ - The package has build time tests. These are more extensive and mock sensor
+   interactions, with a variety of timeouts. 
  
  [Quality assurance - packaging]
  - debian/watch is set up and works.
  - debian/control defines a correct Maintainer field
  - Lintian overrides are not present
  - This package has no python2 or GTK2 dependencies
  - The package will not be installed by default, if iio-sensor-proxy is pulled
    in. The package itself does not use debconf.
  - Packaging and build is easy, link to debian/rules
    
https://salsa.debian.org/DebianOnMobile-team/libssc/-/blob/debian/latest/debian/rules
  
  [UI standards]
  - Application is not end-user facing (does not need translation)
  
  [Dependencies]
  - Used check-mir from ubuntu-dev-tools to validate all dependencies (libc6,
    libglib2.0-0t64, libprotobuf-c1, libqmi-glib5, libqmi-proxy, libqrtr-glib0)
    or recommends are in main.
  
  [Standards compliance]
  - This package correctly follows FHS and Debian Policy
  - Based on a reasonable review of information available at the time of this
    report, no expiry, time-limited grants, or obvious legal encumbrances have
    been identified that would be expected to affect promotion. The current
    licenses in use are the GPLv3 for packaging related files and AGPLv3 for the
    source code.
  
  [Maintenance/Owner]
  - Maintenance can reasonably be inherited from Debian
- - I Suggest the owning team to be Debcrafters. This has been agreed upon with
+ - I suggest the owning team to be Debcrafters. This has been agreed upon with
    @seb128
  - This does not use static builds
  - This does not use vendored code
  - This package is not rust based
  - The package has been built within the last 3 months in the archive
    - Build link on launchpad:
-     https://launchpad.net/ubuntu/+source/libssc/0.4.4-1
+     https://launchpad.net/ubuntu/+source/libssc/0.4.4-2
  - This change will impact Debcrafters due to potentially crashing
    iio-sensor-proxy
  
  [Background information]
  - Upstream Name is libssc
  - Link to upstream project https://codeberg.org/DylanVanAssche/libssc
  - We are currently inheriting the package from Debian.
- - The upstream repository seems to be a single person with occassional
+ - The upstream repository seems to be a single person with occasional
    contributions from other people. Considering that this package is fairly new
    in Debian, this might be subject to change.
  - Upstream is responsive on the bugs as well as committing on a regular basis.
  - The maintainer is actively working on this project since at least 3
    years.
+ - Upstream (Dylan Van Assche) is a trusted contributor in postmarketos
+   (https://postmarketos.org/team/#dylan-van-assche-dylanvanassche)

** Changed in: libssc (Ubuntu)
       Status: Incomplete => New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2159637

Title:
  [MIR] libssc

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libssc/+bug/2159637/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to