Thanks for your contribution! The automated review spotted the following
points:

Needs fixing before this can be sponsored:

* This looks like an SRU, but the bug description doesn't follow the
official SRU bug template
(https://ubuntu.com/project/docs/SRU/reference/bug-template/#reference-
sru-bug-template). The test plan ("Compile test") is too vague to count
as an adequate [Test Plan], since it has no concrete steps and no
runtime check of remain_on_channel/mgmt_tx cookie handling; the [Fix]
section's upstream commit link doesn't substitute for it.

=== resolute (resolute.patch) ===

Nice to have (non-blocking -- none of these block the upload, but you
may want to address them now, before a sponsor reviews this, or in a
future contribution):

* The proposed version doesn't follow Ubuntu's recommended SRU version-
string convention: 0.0~git20240408.aa96a9f+dfsg-8ubuntu2 does not match
expected version 0.0~git20240408.aa96a9f+dfsg-8ubuntu1.1. This isn't
necessarily wrong (what actually matters is that the version sorts ahead
of the archive and doesn't collide with anything), but following the
convention avoids surprises -- see https://ubuntu.com/project/docs/how-
ubuntu-is-made/concepts/version-strings/ for the recommended format.

=== stonking (stonking.patch) ===

Needs fixing before this can be sponsored:

* The fix doesn't appear to have landed in a newer series yet, which SRU policy 
requires before it can land here:
  - `tenacious` (the development release) is still at 
`0.0~git20240408.aa96a9f+dfsg-11` (proposed: 
`0.0~git20240408.aa96a9f+dfsg-11ubuntu1`)

Nice to have (non-blocking -- none of these block the upload, but you
may want to address them now, before a sponsor reviews this, or in a
future contribution):

* The proposed version doesn't follow Ubuntu's recommended SRU version-
string convention: 0.0~git20240408.aa96a9f+dfsg-11ubuntu1 does not match
expected version 0.0~git20240408.aa96a9f+dfsg-11ubuntu0.26.10.1. This
isn't necessarily wrong (what actually matters is that the version sorts
ahead of the archive and doesn't collide with anything), but following
the convention avoids surprises -- see
https://ubuntu.com/project/docs/how-ubuntu-is-made/concepts/version-
strings/ for the recommended format.

The bug status is being set to Incomplete while waiting. Once the points
above are addressed, please set it back to New so the request re-enters
the review queue!

-- 
This is an automated initial review of sponsoring requests. If this review 
seems wrong, please report it at 
https://github.com/canonical/ubuntu-sponsoring-frontdesk/issues

** Changed in: ezurio-qcacld-2.0-dkms (Ubuntu)
       Status: In Progress => Incomplete

** Changed in: ezurio-qcacld-2.0-dkms (Ubuntu Resolute)
       Status: In Progress => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2173882

Title:
  ezurio-qcacld-2.0-dkms fails to build in kernel 7.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ezurio-qcacld-2.0-dkms/+bug/2173882/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to