** Description changed:

+ [ Impact ]
+ 
  ubuntu-raspi-settings ships a dracut config that includes the brcmfmac
  driver but specifies all the needed firmware files. These should be
  included automatically. The brcmfmac kernel module should list those
  modules.
  
  Tested on a Pi 5 stonking docker image with linux-image-7.3.0-5-generic
  7.3.0-5.5:
  
  apt install dracut linux-firmware-raspi ubuntu-raspi-settings
  dracut -f before.img
  3cpio -t before.img > before.txt
  sed -i '/firmware/d' /etc/dracut.conf.d/12-raspi-brcmfmac.conf
  dracut -f after.img
- 3cpio -t after.img > after.txt 
+ 3cpio -t after.img > after.txt
  diff -u before.txt after.txt | grep '^-'
  
  These module will be missing then:
  
  -usr/lib/firmware/brcm/brcmfmac43436-sdio.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43456-sdio.clm_blob.zst
  -usr/lib/firmware/cypress/cyfmac43455-sdio-minimal.bin.zst
  -usr/lib/firmware/brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43430b0-sdio.raspberrypi,model-zero-2-w.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43436-sdio.raspberrypi,model-zero-2-w.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,5-compute-module.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,500.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43456-sdio.raspberrypi,4-compute-module.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43456-sdio.raspberrypi,400.clm_blob.zst
  
  modinfo
  
/lib/modules/7.3.0-5-generic/kernel/drivers/net/wireless/broadcom/brcm80211/brcmfmac/brcmfmac.ko.zst
  shows already some globbing:
  
  firmware:       brcm/brcmfmac*-sdio.*.bin
  firmware:       brcm/brcmfmac*-sdio.*.txt
  firmware:       brcm/brcmfmac*-pcie.*.txcap_blob
  firmware:       brcm/brcmfmac*-pcie.*.clm_blob
  firmware:       brcm/brcmfmac*-pcie.*.bin
  firmware:       brcm/brcmfmac*-pcie.*.txt
  firmware:       brcm/brcmfmac*-pcie.txt
  
  They probably have to add brcm/brcmfmac*-sdio.*.clm_blob and
  cypress/cyfmac43455-sdio-minimal.bin
+ 
+ [ Fix ]
+ 
+ For the kernel, cherry-pick:
+ 8a0f175488bd wifi: brcmfmac: Add per-board clm_blob firmware binaries
+ 37f9b5f2465d wifi: brcmfmac: Add clm_blob firmware for brcmfmac43456-sdio
+ 
+ [ Test Plan ]
+ 
+ [ Where Problems Could Occur ]
+ 
+ For the kernel this just adds additional firmware entries to the
+ .modinfo section of the module. Anything that consumes this data might
+ trip over that new data. initrd size goes up which could cause kernel
+ install failures (out of disk space). Blobs get loaded early which could
+ result in boot hangs, stalls, failures.

** Description changed:

  [ Impact ]
  
  ubuntu-raspi-settings ships a dracut config that includes the brcmfmac
  driver but specifies all the needed firmware files. These should be
  included automatically. The brcmfmac kernel module should list those
  modules.
  
  Tested on a Pi 5 stonking docker image with linux-image-7.3.0-5-generic
  7.3.0-5.5:
  
  apt install dracut linux-firmware-raspi ubuntu-raspi-settings
  dracut -f before.img
  3cpio -t before.img > before.txt
  sed -i '/firmware/d' /etc/dracut.conf.d/12-raspi-brcmfmac.conf
  dracut -f after.img
  3cpio -t after.img > after.txt
  diff -u before.txt after.txt | grep '^-'
  
  These module will be missing then:
  
  -usr/lib/firmware/brcm/brcmfmac43436-sdio.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43456-sdio.clm_blob.zst
  -usr/lib/firmware/cypress/cyfmac43455-sdio-minimal.bin.zst
  -usr/lib/firmware/brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43430b0-sdio.raspberrypi,model-zero-2-w.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43436-sdio.raspberrypi,model-zero-2-w.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,5-compute-module.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,500.clm_blob.zst
  
-usr/lib/firmware/brcm/brcmfmac43456-sdio.raspberrypi,4-compute-module.clm_blob.zst
  -usr/lib/firmware/brcm/brcmfmac43456-sdio.raspberrypi,400.clm_blob.zst
  
  modinfo
  
/lib/modules/7.3.0-5-generic/kernel/drivers/net/wireless/broadcom/brcm80211/brcmfmac/brcmfmac.ko.zst
  shows already some globbing:
  
  firmware:       brcm/brcmfmac*-sdio.*.bin
  firmware:       brcm/brcmfmac*-sdio.*.txt
  firmware:       brcm/brcmfmac*-pcie.*.txcap_blob
  firmware:       brcm/brcmfmac*-pcie.*.clm_blob
  firmware:       brcm/brcmfmac*-pcie.*.bin
  firmware:       brcm/brcmfmac*-pcie.*.txt
  firmware:       brcm/brcmfmac*-pcie.txt
  
  They probably have to add brcm/brcmfmac*-sdio.*.clm_blob and
  cypress/cyfmac43455-sdio-minimal.bin
  
  [ Fix ]
  
  For the kernel, cherry-pick:
  8a0f175488bd wifi: brcmfmac: Add per-board clm_blob firmware binaries
  37f9b5f2465d wifi: brcmfmac: Add clm_blob firmware for brcmfmac43456-sdio
  
  [ Test Plan ]
  
+ Install kernel and:
+ $ Inspect the output of modinfo brcmfmac for the new firmware entries
+ $ Inspect the content of the initrd for the new firmware blobs
+ 
  [ Where Problems Could Occur ]
  
  For the kernel this just adds additional firmware entries to the
  .modinfo section of the module. Anything that consumes this data might
  trip over that new data. initrd size goes up which could cause kernel
  install failures (out of disk space). Blobs get loaded early which could
  result in boot hangs, stalls, failures.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2168109

Title:
  brcmfmac firmware files should be included automatically

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-raspi/+bug/2168109/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to