Hey Zach, thanks for this; a couple of nits that I'd prefer to see fixed
before I upload it:

SRU template:
- Could you explicitly include the affected versions of Ubuntu in the Impact 
section? And/or update the bug tracking information to indicate whether the 
patch has landed in Tenacious & Stonking? (i.e. "Fix Released" in the row for 
devel)
- Test plan covers both package installation & basic afs functionality, +1
- Where problems could occur: Could any regressions happen as a result of 
updating the "Use get_tree_nodev" patch? 
- Other info: Did you mean 1.8.16?

Patches:
- Reviewed patches against upstream with git range-diff, the backport looks 
correct and everything else looks clean
- Updated patch from upstream looks like it introduces no runtime changes. It's 
my understanding that this was done to reduce the number of conflicting hunks 
in the subsequent backport; could you call this out in your changelog entry?
  - If we're also carrying this patch in Stonking/Tenacious, I'm thinking it 
would be preferable to update it there too. Otherwise this is fine with me.
- DEP-3: I was initially confused by your Origin tags; it looks like you 
backported the patch from the upstream openafs-stable-1_8_x instead of upstream 
master. This is fine (sensible, even), but I would prefer that your origin tag 
gave the hash of the commit you picked as the packager, instead of the one it 
was based on originally.

Changelog: good except for version number, please refer to the table of
examples at [1] and/or run ubuntu-lint [2].

[1] 
https://ubuntu.com/project/docs/how-ubuntu-is-made/concepts/version-strings/#table-of-examples
[2] https://github.com/ubuntu/ubuntu-lint

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2173580

Title:
  [SRU] dentry cache becomes stale on kernel >= 6.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/2173580/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to