*** This bug is a security vulnerability ***

Public security bug reported:

The security fix for CVE-2026-59848 only partially backported 9563afc9
on noble and jammy, omitting the hunk that checks the reply ID in
`sftp_get_message`:

```
@@ -842,9 +844,63 @@ static sftp_message sftp_get_message(sftp_packet packet)
             msg->id,
             msg->packet_type);
 
+    /* Validate that this ID is in our outstanding requests list */
+    id_it = ssh_list_get_iterator(sftp->outstanding_ids);
+    for (; id_it != NULL; id_it = id_it->next) {
+        uint32_t *stored_id = (uint32_t *)id_it->data;
+        if (*stored_id == msg->id) {
+            id_found = true;
+            ssh_list_remove(sftp->outstanding_ids, id_it);
+            free(stored_id);
+            break;
+        }
+    }
+
+    if (!id_found) {
+        ssh_set_error(packet->sftp->session,
+                      SSH_FATAL,
+                      "Unknown request ID %" PRIu32,
+                      msg->id);
+        sftp_message_free(msg);
+        sftp_set_error(packet->sftp, SSH_FX_FAILURE);
+        return NULL;
+    }
+
     return msg;
 }
```

The security fix for CVE-2026-59846 in noble and jammy are missing a
follow-up patch that adds `ssh_check_username_syntax` in
`ssh_config_parse_uri`, introduced in d97a5930.

** Affects: libssh (Ubuntu)
     Importance: Undecided
     Assignee: Kyle Kernick (kkernick)
         Status: In Progress

** Affects: libssh (Ubuntu Jammy)
     Importance: Undecided
     Assignee: Kyle Kernick (kkernick)
         Status: Confirmed

** Affects: libssh (Ubuntu Noble)
     Importance: Undecided
     Assignee: Kyle Kernick (kkernick)
         Status: Confirmed

** Changed in: libssh (Ubuntu)
       Status: New => In Progress

** Changed in: libssh (Ubuntu)
     Assignee: (unassigned) => Kyle Kernick (kkernick)

** Also affects: libssh (Ubuntu Jammy)
   Importance: Undecided
       Status: New

** Also affects: libssh (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Changed in: libssh (Ubuntu Jammy)
       Status: New => Confirmed

** Changed in: libssh (Ubuntu Noble)
       Status: New => Confirmed

** Changed in: libssh (Ubuntu Jammy)
     Assignee: (unassigned) => Kyle Kernick (kkernick)

** Changed in: libssh (Ubuntu Noble)
     Assignee: (unassigned) => Kyle Kernick (kkernick)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2174440

Title:
  Incomplete fix for CVE-2026-59846 and CVE-2026-59848

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/2174440/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to