Public bug reported:

This bug targets the linux-amd-embedded kernel (Ubuntu 26.04 Resolute,
7.0, amd64). linux-amd-embedded is not yet available in the archive, so
the bug is filed against the linux package for now.

[Impact]
The AMD PCIe FPGA dynamic I/O drivers in linux-amd-embedded (LP: #2173734) are 
missing the following fixes and features:
 * AXI Ethernet (dmaengine path): the TX ring head is advanced before the 
descriptor is ready. If DMA mapping or descriptor preparation fails, the next 
TX completion uses a wrong ring slot and can dereference a NULL or stale skb.
 * Xilinx CAN FD: the BRS and ESI flags of received frames are not passed to 
SocketCAN, so applications cannot see them.
 * Xilinx XADC: the driver sets the wrong write edge in the XADC interface 
configuration.
 * AMD PCIe FPGA overlay: the overlay stored in the FPGA Config BRAM cannot be 
xz-compressed, the clock providers are declared under the MMIO bus node, and 
the RS485 UART in the embedded overlay uses the generic UART Lite compatible.
 * DT bindings: the XADC binding is still in text format, and the frame buffer 
binding does not declare #dma-cells.

[Fix]
 * Backport from mainline (v7.4-rc1), adapted to the multi-queue dmaengine path 
of linux-amd-embedded:
   - cb790252f8e1 ("net: axienet: don't advance the TX ring head before the 
descriptor is ready")
 * UBUNTU: SAUCE patches from the AMD patch set:
   - drivers: iio: adc: xadc: Correct Write edge in CFG
   - dt-bindings: iio: adc: xlnx,axi-xadc: convert to DT schema
   - can: xilinx_can: set CAN FD flags on received frames
   - misc: amd_pcie_fpga_overlay: support xz-compressed DTBO in Config BRAM
   - misc: amd_pcie_fpga_overlay: move clock providers to the overlay root
   - misc: amd_pcie_fpga_overlay: fix rs485 UART compatible string
   - dt-bindings: dma: xilinx: frmbuf: Add #dma-cells

[Test Plan]
 * Build the linux-amd-embedded kernel for all flavours and check that 
updateconfigs passes.
 * Boot the kernel in an LXD VM and load the amd-pcie-fpga-overlay, xilinx_can, 
xilinx_emac and xilinx-xadc modules.

[Where problems could occur]
The changes affect the AXI Ethernet TX path, the Xilinx CAN FD receive path, 
the XADC configuration and the AMD PCIe FPGA overlay driver. A regression could 
cause network TX errors, wrong CAN FD frame flags, wrong XADC readings, or the 
FPGA devices not being created when the overlay is applied. The drivers are 
only used with the Xilinx IP in the PCIe-attached FPGA.

** Affects: linux (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: linux (Ubuntu Resolute)
     Importance: High
     Assignee: Krystian Kaniewski (kkaniewski)
         Status: Confirmed

** Description changed:

  This bug targets the linux-amd-embedded kernel (Ubuntu 26.04 Resolute,
  7.0, amd64). linux-amd-embedded is not yet available in the archive, so
  the bug is filed against the linux package for now.
  
  [Impact]
- The AMD PCIe FPGA dynamic I/O drivers for the Kria AI Robotics platform in 
linux-amd-embedded (LP: #2173734) are missing the following fixes and features:
+ The AMD PCIe FPGA dynamic I/O drivers in linux-amd-embedded (LP: #2173734) 
are missing the following fixes and features:
   * AXI Ethernet (dmaengine path): the TX ring head is advanced before the 
descriptor is ready. If DMA mapping or descriptor preparation fails, the next 
TX completion uses a wrong ring slot and can dereference a NULL or stale skb.
   * Xilinx CAN FD: the BRS and ESI flags of received frames are not passed to 
SocketCAN, so applications cannot see them.
   * Xilinx XADC: the driver sets the wrong write edge in the XADC interface 
configuration.
   * AMD PCIe FPGA overlay: the overlay stored in the FPGA Config BRAM cannot 
be xz-compressed, the clock providers are declared under the MMIO bus node, and 
the RS485 UART in the embedded overlay uses the generic UART Lite compatible.
   * DT bindings: the XADC binding is still in text format, and the frame 
buffer binding does not declare #dma-cells.
  
  [Fix]
   * Backport from mainline (v7.4-rc1), adapted to the multi-queue dmaengine 
path of linux-amd-embedded:
     - cb790252f8e1 ("net: axienet: don't advance the TX ring head before the 
descriptor is ready")
   * UBUNTU: SAUCE patches from the AMD patch set:
     - drivers: iio: adc: xadc: Correct Write edge in CFG
     - dt-bindings: iio: adc: xlnx,axi-xadc: convert to DT schema
     - can: xilinx_can: set CAN FD flags on received frames
     - misc: amd_pcie_fpga_overlay: support xz-compressed DTBO in Config BRAM
     - misc: amd_pcie_fpga_overlay: move clock providers to the overlay root
     - misc: amd_pcie_fpga_overlay: fix rs485 UART compatible string
     - dt-bindings: dma: xilinx: frmbuf: Add #dma-cells
  
  [Test Plan]
   * Build the linux-amd-embedded kernel for all flavours and check that 
updateconfigs passes.
   * Boot the kernel in an LXD VM and load the amd-pcie-fpga-overlay, 
xilinx_can, xilinx_emac and xilinx-xadc modules.
  
  [Where problems could occur]
- The changes affect the AXI Ethernet TX path, the Xilinx CAN FD receive path, 
the XADC configuration and the AMD PCIe FPGA overlay driver. A regression could 
cause network TX errors, wrong CAN FD frame flags, wrong XADC readings, or the 
FPGA devices not being created when the overlay is applied. The drivers are 
only used with the Xilinx IP in the FPGA on the Kria AI Robotics platform.
+ The changes affect the AXI Ethernet TX path, the Xilinx CAN FD receive path, 
the XADC configuration and the AMD PCIe FPGA overlay driver. A regression could 
cause network TX errors, wrong CAN FD frame flags, wrong XADC readings, or the 
FPGA devices not being created when the overlay is applied. The drivers are 
only used with the Xilinx IP in the PCIe-attached FPGA.

** Also affects: linux (Ubuntu Resolute)
   Importance: Undecided
       Status: New

** Changed in: linux (Ubuntu Resolute)
     Assignee: (unassigned) => Krystian Kaniewski (kkaniewski)

** Changed in: linux (Ubuntu Resolute)
   Importance: Undecided => High

** Changed in: linux (Ubuntu Resolute)
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2174581

Title:
  linux-amd-embedded: Update the AMD PCIe FPGA dynamic I/O drivers

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2174581/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to