Hey Dean, thanks for the awesome work here. I didn't have time for a
full review this afternoon but a couple of general feedback items that I
think would make this easier to review:
My initial impression from reading the template and looking at the
upstream patches is that this looks like two separate bugs with very
similar impact. Is it possible to reproduce the hangs independently or
are they so similar that it's not easy to tell which one you're running
into? If the bugs are independently reproducible it might improve
clarity to split the entire SRU into two bugs and handle each case
separately. You'd still only need to file one merge proposal for each
series containing the fixes for both; just the SRU
documentation/changelog entries would be separate.
The section "Who is impacted" suggests that some non-default configs are
required in order to reproduce this (at least in some cases); the
relationships between these settings and the behavior a user sees is
still foggy for me with the description here. While I'm not necessarily
opposed to reviewing LLM-generated content, I personally would prefer
that you curated the output a little more aggressively so that it's
easier for your reviewers to understand (especially in the Impact/Where
problems could occur sections; readability is somewhat less critical for
the others).
Your Impact section includes a root cause analysis and links to the
upstream fixes; these are good to include in the template but they
should be in the [ Other info ] section since they don't describe the
impact of the bug on an end-user.
For the test plan, the "How the Test Works" and "Release differences"
sections are a bit impenetrable; instead of including this information
in the template, could you work it into the reproducer scripts
themselves as terse comments so that the special cases are proximate to
where they are implemented/relevant?
For the missing Tenacious desktop image, let's have a chat with Simon on
the LXD team to see about getting one of those published so we don't
need a special case in the test plan. Source code is at [1]. Strictly
speaking verification isn't needed for Tenacious but it's worth checking
anyway once the package is in tenacious-proposed.
In your changelog, could you use sub-bullet style? That way the most
important information is first, followed by the (important, but less so)
details:
* Backport upstream fix (GNOME MR !4455) so that gnome-shell finishes
starting up when the monitor layout changes during the overview
startup animation, instead of leaving an input-blocking cover pane
on screen (LP: #2174851)
- d/p/lp2174851-workspacesView-Update-views-on-monitor-changes.patch
- d/p/lp2174851-overview-Stop-hiding-on-monitor-changes.patch
Additionally, your changelog entry should give the user the information
they need to decide if they want to install this package update or not.
"GNOME MR !4455" is likely meaningless to most users; what about "Fix
gray-screen hang when the monitor layout changes during the overview
startup animation (LP: #2174851)"?
[1] https://github.com/canonical/lxd-
imagebuilder/blob/main/images/ubuntu.yaml
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2174851
Title:
gnome-shell startup stuck forever when monitor layout changes during
the overview startup animation
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/2174851/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs