Hey Bhavya, thanks for this.
The SRU template looks great.
- If possible it would be nice to include instructions for how you set up the
test plan environment (LXD VMs? Multipass? something else?), that way it's easy
to reproduce this for anybody who comes across the bug.
- In [ Other Info ] you say "That os-prober defect is currently masked by this
very AppArmor gap"; does this patch have any effect on the brokenness of
os-prober/linux-boot-prober? If making this change risks changing the behavior
of those packages then it should be documented under [ Where problems could
occur ].
- nit: You can skip the "Update the apparmor profile"/"sudo nano" bit; you can
just say "Before the fix"/"After the fix"
For your patch, a few things:
- In my reading of the DEP-3 spec, you need to include an "Author" field to
make "Origin" optional [1]
- I realize that this is a modification to some of the delta that we carry in
Ubuntu, but we should still forward those changes upstream if possible (even if
"upstream" in this case is just a comment on a merge proposal). Could you add a
review comment (or two) to the upstream MR so that this change is documented
upstream?
- nit: It would be nice to include a "why" for the change in the extended patch
description, although this is mostly covered by the LP bug and/or upstream MR
comments
Could you update the tracking info on this bug ("Target to series") so
that we know which releases of Ubuntu are affected and will need the
patch? (And maybe also clarify which releases are affected in your [
Impact ] section)
I'm not able to upload to -devel; we should coordinate with the AppArmor
team to request review of the change (and maybe see if they will merge
the upstream MR).
[1] https://dep-team.pages.debian.net/deps/dep3/
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2171055
Title:
linux-boot-prober profile missing LVM rules breaks LVM dual-
boot/snapshot detection
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/2171055/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs