Thanks for the work, a few comments.
* Generally when doing merges, the launchpad bug numbers are not needed in the
changelog entry,as they should already be documented earlier in the changelog
from prior changes to the Ubuntu package.
* Please add this bug number to the changelog entry, so this bug is closed when
the upload is done, a good place is on the line stating that it is a merge, as
follows:
* Merge from debian unstable (LP: #229052), remaining changes:
Note that the syntax is the same as the other bug numbers in the changelog
entry, with the exception of the bug number itself.
* You added a patch, and you noted as such in the changelog, but you
didn't explain why. If you could mention why you added this patch, and
what it fixes, that would be great. You might also consider sending the
patch upstream to the alsa project, or Debian.
Other than that, looks good.
** Changed in: alsa-tools (Ubuntu)
Status: New => Incomplete
--
Please merge alsa-tools 1.0.16-1 from Debian unstable (main)
https://bugs.launchpad.net/bugs/229052
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
