Hi Gordon, Gordon Mckeown [2008-07-22 8:33 -0000]: > Martin, I'm interested to know more about your thoughts on the change > from strtoul from strtoll. The function name indicates that it sets a > uint64, but would strtoll not set a signed 64-bit int? That was the > logic behind changing it to use strtoul, so I'm keen to know if I've > completely misunderstood something!
No, that is of course correct, but is independent from the fix for this bug (and, TBH, I think it's pretty irrelevant, too, given the size of 64 bit integers it hardly matters...) The original workaround proposed here was to use a 64 bit strtoll in the 32 bit hal_util_set_int_from_file() function, which is wrong. My patch actually uses hal_util_set_uint64_from_file() for volume.num_blocks. -- 2.6.24 reports invalid storage size in /sys [Sony Walkman NWZ-S618F doesn't mount in Hardy] https://bugs.launchpad.net/bugs/209483 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
