Review: Needs Fixing thanks, almost there, just a couple of changes to request please (see the diff comments)
Diff comments: > diff --git a/debian/patches/data-61-gdm.rules.in.patch > b/debian/patches/data-61-gdm.rules.in.patch > new file mode 100644 > index 0000000..77146bf > --- /dev/null > +++ b/debian/patches/data-61-gdm.rules.in.patch > @@ -0,0 +1,23 @@ > +From: Bin Li <bi...@gnome.org> > +Date: Wed, 29 Aug 2018 16:47:46 +0800 > +Subject: data: 61-gdm.rules.in > + > +Disable wayland for Huawei Hi1710 chipsets. > + > +The login screen is skewed/distorted on arm server, and I couldn't > +find root cause, and no other developer ever has access to the hardware. > + > +https://gitlab.gnome.org/GNOME/mutter/issues/219 Please could you add add DEP-3 metadata here so that people in the future can easily find out where the patch comes from? At the end of the description, add: Bug-Ubuntu: <launchpad link> Bug: <upstream bug>, Origin: <link to commit in gitlab> > +--- > + data/61-gdm.rules.in | 2 ++ > + 1 file changed, 2 insertions(+) > + > +diff --git a/data/61-gdm.rules.in b/data/61-gdm.rules.in > +index de8e179..c9f6110 100644 > +--- a/data/61-gdm.rules.in > ++++ b/data/61-gdm.rules.in > +@@ -1,2 +1,4 @@ > + # disable Wayland on Cirrus chipsets > + ATTR{vendor}=="0x1013", ATTR{device}=="0x00b8", > ATTR{subsystem_vendor}=="0x1af4", ATTR{subsystem_device}=="0x1100", > RUN+="@libexecdir@/gdm-disable-wayland" > ++# disable Wayland on Hi1710 chipsets > ++ATTR{vendor}=="0x19e5", ATTR{device}=="0x1711", > RUN+="@libexecdir@/gdm-disable-wayland" > diff --git a/debian/patches/data-Makefile.am.patch > b/debian/patches/data-Makefile.am.patch > new file mode 100644 > index 0000000..461f07b > --- /dev/null > +++ b/debian/patches/data-Makefile.am.patch > @@ -0,0 +1,23 @@ > +From: Bin Li <bi...@gnome.org> > +Date: Thu, 23 Aug 2018 15:15:24 +0800 > +Subject: data: Makefile.am > + > +The $prefix was /usr in general, but rules in /usr/lib/udev/ can't > +be loaded by udev, so just remove it. same here > +--- > + data/Makefile.am | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/data/Makefile.am b/data/Makefile.am > +index a56f32d..774f2cb 100644 > +--- a/data/Makefile.am > ++++ b/data/Makefile.am > +@@ -160,7 +160,7 @@ if ENABLE_ARCH_PAM_CONFIG > + pam_files = $(pam_arch_files) > + endif > + > +-udevrulesdir = $(prefix)/lib/udev/rules.d > ++udevrulesdir = /lib/udev/rules.d > + udevrules_DATA = 61-gdm.rules > + > + EXTRA_DIST += $(srcdir)/61-gdm.rules.in > diff --git a/debian/patches/install-udev-rules-in-the-correct-folder.patch > b/debian/patches/install-udev-rules-in-the-correct-folder.patch > new file mode 100644 > index 0000000..5834c0a > --- /dev/null > +++ b/debian/patches/install-udev-rules-in-the-correct-folder.patch > @@ -0,0 +1,24 @@ > +From: Didier Roche <didro...@ubuntu.com> > +Date: Wed, 5 Sep 2018 09:40:04 +0200 > +Subject: install udev rules in the correct folder > + > +* debian/gdm3.install: > + - install udev rules in the correct folder (following upstream build > + fixes) > +--- > + debian/gdm3.install | 2 +- This one should not be a Debian patch - a patch should never patch the debian/ directory itself. Please make this change directly. > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/debian/gdm3.install b/debian/gdm3.install > +index c69747c..b7438b8 100644 > +--- a/debian/gdm3.install > ++++ b/debian/gdm3.install > +@@ -3,7 +3,7 @@ lib/systemd/ > + lib/*/security/*.so > + usr/bin/gdm-screenshot > + usr/lib/gdm3/gdm-* > +-usr/lib/udev > ++lib/udev > + # gets renamed to gdm3 in binary-install > + usr/sbin/gdm > + usr/share/pixmaps/ -- https://code.launchpad.net/~binli/ubuntu/+source/gdm3/+git/gdm3/+merge/354933 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
