Amit Kucheria wrote:
On Fri, Mar 7, 2008 at 5:46 PM, Tony Espy <[EMAIL PROTECTED]> wrote:
 my patches are were generated from local git commits made to a clone of
 the latest hardy-lum tree.

 i re-named the 8686 driver directory from /8686_v9 ( which isn't an
 appropriate name for the driver IMHOP ) to /8686_wlan which is why the
 driver tree was effectively replaced.

I am afraid I didn't like the way you did those patches, since they
combined the renaming operation with the bit that makes WPA work.

I redid the patches to split out the changes a little better:

Patch 1 - move 8686_v9 -> 8686_wlan (using git-mv)
Patch 2 - Fix naming of driver module in makefile
Patch 3 - Make it work with wpa

Could you confirm that this works for you?

i just diff'd your changes to lum against my kernel tree and it looks fine to me. the only diff was the Makefile/ temp fix for CONFIG_MMC_SD8686.

Patch 3 is also a little suspect, since you seem to comment out
SET_DRVER_OWNER, etc. Could you please confirm why that is needed?

please re-check my patch. i didn't comment out SET_MODULE_OWNER, i removed it. it was commented out by feng when he ported v9 to 2.6.24. SET_MODULE_OWNER was deprecated in 2.6.23 and removed in 2.6.24.

fyi, i'm also attaching a new patch which updates the 8688_wlan driver WPA/WPA2 support ( i missed this in my original patch to you ). feng just added this to both kernel git trees at moblin.org.

thanks for your help!

ciao,
/tony
>From 451590877b39cc6c62acd26906e93d4f95332b2c Mon Sep 17 00:00:00 2001
From: Tony Espy <[EMAIL PROTECTED]>
Date: Mon, 10 Mar 2008 14:05:30 -0400
Subject: [PATCH] Enable WPA/WPA2 support

Signed-off-by: Tony Espy <[EMAIL PROTECTED]>
---
 ubuntu/wireless/marvell/8688_wlan/wlan/wlan_wext.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ubuntu/wireless/marvell/8688_wlan/wlan/wlan_wext.c 
b/ubuntu/wireless/marvell/8688_wlan/wlan/wlan_wext.c
index 0b7d0b4..37f0f90 100644
--- a/ubuntu/wireless/marvell/8688_wlan/wlan/wlan_wext.c
+++ b/ubuntu/wireless/marvell/8688_wlan/wlan/wlan_wext.c
@@ -2788,6 +2788,13 @@ wlan_get_range(struct net_device *dev, struct 
iw_request_info *info,
     range->num_txpower = 2;
     range->txpower_capa = IW_TXPOW_DBM | IW_TXPOW_RANGE;
 
+    if (FW_IS_WPA_ENABLED(Adapter)) {
+       range->enc_capa = IW_ENC_CAPA_WPA
+           | IW_ENC_CAPA_WPA2
+           | IW_ENC_CAPA_CIPHER_TKIP
+           | IW_ENC_CAPA_CIPHER_CCMP;
+    }
+
     LEAVE();
     return WLAN_STATUS_SUCCESS;
 }
-- 
1.5.2.5

-- 
Ubuntu-mobile mailing list
Ubuntu-mobile@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-mobile

Reply via email to