I don't really understand why we need to add a conditional at all. It's
always safe to run resolvconf -u one time too many; but running it one
time too few will introduce subtle bugs (like this one).

The proposed conditional only suppresses running resolvconf -u if
ENABLED=1 and resolvconf is not being used (ie IGNORE_RESOLVCONF=yes).
Is this really such a common case that adding complexity to get the
minor optimization of not running resolvconf -u is worth it?

Also, doesn't your argument about ENABLED=0 later being changed to
ENABLED=1 also apply to IGNORE_RESOLVCONF=yes later being changed to
IGNORE_RESOLVCONF=no?

I'm still in favour of just unconditionally running resolvconf -u, as my
branch does.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to dnsmasq in Ubuntu.
https://bugs.launchpad.net/bugs/1247803

Title:
  dnsmasq temporarily breaks DNS resolution when starting for the first
  time

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dnsmasq/+bug/1247803/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

Reply via email to