@Mathias: That's fine.  I was just following the example set by some
other parameters in that same file, very close to the line being
discussed, such as

  set_postfix_option "smtpd_tls_mandatory_protocols = SSLv3, TLSv1"

and also

  set_postfix_option "tls_random_source = dev:/dev/urandom"

which seem to me to be setting things to the same value as the default.
I therefore thought there must be a reason for doing it this way, and so
I carefully followed the example set by the creators of this script :)

I think it would be good to be consistent about this, and *only* set
things which are non-default, unless there really is a valid reason for
doing otherwise?

Attached is a new debdiff that just removes the one line for
smtpd_tls_mandatory_ciphers.  If you feel we should also remove the
others that set things the same as the default, let me know :)

BTW, I looked at doing this as a bzr branch, but was puzzled by the
branch name being ubuntu-intrepid, so I just did a debdiff instead,
rather than risk a mistake of using the wrong bzr branch!


Jonathan

** Attachment added: "dovecot-lp365390.debdiff"
   http://launchpadlibrarian.net/26826590/dovecot-lp365390.debdiff

** Tags added: patch

-- 
postfix:  invalid value for smtpd_tls_mandatory_ciphers in main.cf
https://bugs.launchpad.net/bugs/365390
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to dovecot in ubuntu.

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

Reply via email to