Robie / Chris,

Can you review comment #6 for the proposed patch and upgrade
issue/strategy?

The upstart config for freeradius is bad; reload(8) or restart(8) will
lose track of the process.  A reload won't send SIGHUP to the right
process and a restart(8) will  not stop the existing freeradius process;
in either case upstart loses track of the process and thinks the service
has stopped, further attempts to start the service will fail because of
the existing process holding the port open.  The patch fixes this for
new, clean starts of the service but on a running system I don't think
we have a way to make things better without manual intervention ('pkill
freeradius' when the user can afford to take the process down) or a
reboot.

I might be missing something clever, but I doubt there is a good way to
fix this for the different states we might find things in during
upgrade.

Scenarios:
1 - freeradius is not running.  Upgrading the package is great.
2 - freeradius is runing and 'reload/restart' has been called previously (i.e. 
upstart can't manage the freeradius process).  Upgrading will not regress the 
system because upstart could not manage the service prior to package upgrade.
3 - freeradius is running and 'reload/restart' has never been called  (i.e. 
upstart can still stop the process properly).  Upgrading will fix logrotate and 
the next rotation will call 'reload freeradius' causing upstart to lose track 
of the process.  It can no longer be stopped by upstart.

The only issue is scenario #3 which regresses the user's ability to stop
freeradius *if* they have not tried to reload or restart the service.  I
don't think that we can take the action to restart the service on
package upgrade if upstart can still manage the service due to service
interruption.  The next logrotation attempt will ensure that the user
can not manage freeradius from upstart.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

Reply via email to