cypermox said by email: > it seems to me like not removing the .syso files, which are both > arch-dependent and prebuilt binaries we cannot verify have been > built with the source provided (even if there is strong suspicion > that they were) is the wrong approach to fixing these > tests.
This is one of those things where you are totally correct, but this problem totally predates my changes :-) These syso files were distributed before, just harder to find: $ mkdir /tmp/golang-race $ cd /tmp/golang-race $ chdist apt-get sid download golang-go-linux-amd64 Get:1 http://ftp.debian.org/debian/ unstable/main golang-go-linux-amd64 amd64 2:1.4.2-3 [8,696 kB] Fetched 8,696 kB in 12s (724 kB/s) $ dpkg-deb -x golang-go-linux-amd64_2%3a1.4.2-3_amd64.deb . $ ar x usr/lib/go/pkg/linux_amd64/runtime/race.a $ ls _go_.6 golang-go-linux-amd64_2%3a1.4.2-3_amd64.deb __.PKGDEF race_linux_amd6 usr $ diff race_linux_amd6 ~/go1.4/src/runtime/race/race_linux_amd64.syso && echo same same > Instead, I think these files should be built as part of > the build process for golang, or the tests used to report the bug > fixed. The former sort of makes sense, the latter part doesn't: these are not inputs to test cases, they are required for functionality that has worked until now (Go's race detector). The process to build them is explained here: https://github.com/golang/go/blob/master/src/runtime/race/README -- it sounds like automating this enough to be done as part of a package build is feasible (but not trivial). > Either way, I'm not familiar enough with go to have an > opinion, but if you need help I can dig deeper :) > Those are not > the only files I'm wondering about, there are multiple other > binaries that probably shouldn't be included in the upstream > tarball... have you brought this up upstream? All the other stuff I am aware of is things like input for the elf parser tests. Are those what you mean? If so, I don't think upstream would be terribly impressed in our suggestion that they not be included. (They are built from source in the tree, but not as part of the build process -- some of them are testing behaviour against very specific toolchain versions, for one thing). -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to golang in Ubuntu. https://bugs.launchpad.net/bugs/1487928 Title: please upload 1.5 final packages To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang/+bug/1487928/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
