** Description changed: [Impact] - * An explanation of the effects of the bug on users and + Updating the smart driver db fails because the tool selected by the + script (curl) is not called with a parameter that allows it to follow + redirects. Since upstream changed the URL for that driver file, the + script now fails. - * justification for backporting the fix to the stable release. - - * In addition, it is helpful, but not required, to include an - explanation of how the upload fixes this bug. + The fix is to just add -L to the curl command line. [Test Case] + sudo apt-get install smartmontools --no-install-recommends + sudo update-smart-drivedb + /var/lib/smartmontools/drivedb/drivedb.h.error: rejected by /usr/sbin/smartctl, probably no longer compatible - * detailed instructions how to reproduce the bug + The file /var/lib/smartmontools/drivedb/drivedb.h.error contains the redirect notice: + <h1>302 Found</h1> + The resource was found at <a href="https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/RELEASE_6_2_DRIVEDB/smartmontools/drivedb.h?format=raw";>https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/RELEASE_6_2_DRIVEDB/smartmontools/drivedb.h?format=raw</a>; + you should be redirected automatically. - * these should allow someone who is not familiar with the affected - package to reproduce the bug and verify that the updated package fixes - the problem. + Update the packages and run the command again, this time it will + succeed: + [Regression Potential] - - * discussion of how regressions are most likely to manifest as a result - of this change. - - * It is assumed that any SRU candidate patch is well-tested before - upload and has a low overall risk of regression, but it's important - to make the effort to think about what ''could'' happen in the - event of a regression. - - * This both shows the SRU team that the risks have been considered, - and provides guidance to testers in regression-testing the SRU. + If there is a redirect loop, before it wouldn't be followed, and now it will. There is a default limit of 50, though (--max-redirs' default), so eventually it will stop and fail (correctly). [Other Info] - - * Anything else you think is useful to include - * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board - * and address these questions in advance + Later supported releases of Ubuntu and Debian have dropped this script from the package, so no fix is necessary there. + + Following the spirit of the smallest change possible, I chose to not + change the URL from where the file is downloaded. [Original Description] Package: smartmontools-6.1+svn3812-1 and older. Due to sourceforge platform upgrades (http://sourceforge.net/blog /upgrades-april22/), the smartmontools SVN repository was moved to a new location. The update-smart-drivedb script from a smartmontools build before r3814 downloads drivedb.h from the old respository which is still present but set to R/O. Possible fix: - Update to smartmontools 6.2 (final, r3841), or - Replace update-smart-drivedb with a new one generated from 6.2 tarball. Adjust the branch version number in line 'BRANCH="RELEASE_6_2_DRIVEDB"'. This should work for smartmontools 5.40 to 6.1. These drivedb.h branches are still maintained.
-- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to smartmontools in Ubuntu. https://bugs.launchpad.net/bugs/1209085 Title: update-smart-drivedb uses old download link To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
