-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Neeraj,

I've been at DebConf for the past week, so I haven't had a lot of time
to work on Ubuntu Sugarteam things. I'm CCing the list on this mail so
that everyone can learn from my comments.

On 08/07/2010 05:59 PM, Neeraj Gupta wrote:
> Can you please sponsor my patch for Mouse Bug[1].
> I have applied patch provided by alsroot when we were facing this problem.
> https://bugs.launchpad.net/ubuntu/+source/sugar-0.88/+bug/511225

I'm attaching your debdiff so we can refer to it later if you refactor
it in Launchpad.

In your debdiff, you include a file,
'debian/patches/debian-changes-0.88.1-2ubuntu2', as a patch. This patch
title is incredibly non-descriptive; it tells me nothing about the patch
contents. Look at the other patches in the debian/patches directory for
ideas on suitable names.

Also, I noticed your patch has the autogenerated headers above it. The
point of these headers is to document the status, origin, and author of
the patch. DEP3[1] is an attempt to codify ways to document patches.

Please document your patch as indicated above and resubmit.

Important questions to consider and answer: Where did the patch come
from? Has it been submitted upstream to Debian? To Sugar Labs?

[1]: http://dep.debian.net/deps/dep3/

- -- 
Luke Faraone
http://luke.faraone.cc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxe+M8ACgkQtrC51grHAgYscwCeIWpi6GofiEd8S8aybW50kWKJ
wBIAoJSjHWyvUV2jRXvufxAoD2zIetuz
=GGqK
-----END PGP SIGNATURE-----
diff -Nru sugar-0.88-0.88.1/debian/changelog sugar-0.88-0.88.1/debian/changelog
--- sugar-0.88-0.88.1/debian/changelog  2010-07-24 21:17:20.000000000 +0530
+++ sugar-0.88-0.88.1/debian/changelog  2010-07-31 04:58:58.000000000 +0530
@@ -1,3 +1,9 @@
+sugar-0.88 (0.88.1-2ubuntu2) maverick; urgency=low
+
+  * Fixed mouse bug. (LP: #511225) 
+
+ -- Neeraj Gupta <[email protected]>  Sat, 31 Jul 2010 04:56:56 +0530
+
 sugar-0.88 (0.88.1-2ubuntu1) maverick; urgency=low
 
   * Merge from debian unstable(LP: #609412). Remaining changes:
diff -Nru sugar-0.88-0.88.1/debian/patches/debian-changes-0.88.1-2ubuntu2 
sugar-0.88-0.88.1/debian/patches/debian-changes-0.88.1-2ubuntu2
--- sugar-0.88-0.88.1/debian/patches/debian-changes-0.88.1-2ubuntu2     
1970-01-01 05:30:00.000000000 +0530
+++ sugar-0.88-0.88.1/debian/patches/debian-changes-0.88.1-2ubuntu2     
2010-07-31 05:01:59.000000000 +0530
@@ -0,0 +1,36 @@
+Description: Upstream changes introduced in version 0.88.1-2ubuntu2
+ This patch has been created by dpkg-source during the package build.
+ Here's the last changelog entry, hopefully it gives details on why
+ those changes were made:
+ .
+ sugar-0.88 (0.88.1-2ubuntu2) maverick; urgency=low
+ .
+   * Fixed mouse bug. (LP: #511225)
+ .
+ The person named in the Author field signed this changelog entry.
+Author: Neeraj Gupta <[email protected]>
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/511225
+
+---
+The information above should follow the Patch Tagging Guidelines, please
+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
+are templates for supplementary fields that you might want to add:
+
+Origin: <vendor|upstream|other>, <url of original patch>
+Bug: <url in upstream bugtracker>
+Bug-Debian: http://bugs.debian.org/<bugnumber>
+Forwarded: <no|not-needed|url proving that it has been forwarded>
+Reviewed-By: <name and email of someone who approved the patch>
+Last-Update: <YYYY-MM-DD>
+
+--- sugar-0.88-0.88.1.orig/bin/sugar-session
++++ sugar-0.88-0.88.1/bin/sugar-session
+@@ -230,7 +230,7 @@ def main():
+ 
+     client = gconf.client_get_default()
+     client.set_string('/apps/metacity/general/mouse_button_modifier',
+-                      'disabled')
++                      '<Super>')
+ 
+     timezone = client.get_string('/desktop/sugar/date/timezone')
+     if timezone is not None and timezone:
diff -Nru sugar-0.88-0.88.1/debian/patches/series 
sugar-0.88-0.88.1/debian/patches/series
--- sugar-0.88-0.88.1/debian/patches/series     2010-07-20 16:05:12.000000000 
+0530
+++ sugar-0.88-0.88.1/debian/patches/series     2010-07-31 04:59:12.000000000 
+0530
@@ -3,3 +3,4 @@
 #fix_tz_config_path.patch
 #danish_l10n_autotools.patch
 empy_from_system_autotools.patch
+debian-changes-0.88.1-2ubuntu2

Attachment: sugar-0.88_0.88.1-2ubuntu1.debdiff.txt.sig
Description: Binary data

-- 
Ubuntu-sugarteam mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-sugarteam

Reply via email to