Riccardo Padovani has proposed merging 
lp:~rpadovani/reminders-app/fixRightAction into lp:reminders-app.

Commit message:
Disable triggerActionOnMouseRelease on right swype, as requested by design 
guidelines. Fixes #1430158.

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)

For more details, see:
https://code.launchpad.net/~rpadovani/reminders-app/fixRightAction/+merge/252549

https://design.ubuntu.com/apps/building-blocks/list-items#actions

To reveal trailing positive actions, the user simply swipes right to left to 
reveal actions inside the item. Users need to swipe and then tap on the icon to 
execute the action.

Fixes #1430158.
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed 
merge of lp:~rpadovani/reminders-app/fixRightAction into lp:reminders-app.
=== modified file 'src/app/qml/ui/NotebooksPage.qml'
--- src/app/qml/ui/NotebooksPage.qml	2015-03-04 00:23:45 +0000
+++ src/app/qml/ui/NotebooksPage.qml	2015-03-11 10:05:03 +0000
@@ -119,7 +119,6 @@
             delegate: NotebooksDelegate {
                 width: parent.width
                 height: units.gu(10)
-                triggerActionOnMouseRelease: true
 
                 onItemClicked: {
                     print("selected notebook:", model.guid)

=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2015-03-08 18:47:51 +0000
+++ src/app/qml/ui/NotesPage.qml	2015-03-11 10:05:03 +0000
@@ -161,7 +161,6 @@
                       model.updated : model.created
 
             content: model.tagline
-            triggerActionOnMouseRelease: true
             tags: {
                 var tags = new Array();
                 for (var i = 0; i < model.tagGuids.length; i++) {

=== modified file 'src/app/qml/ui/RemindersPage.qml'
--- src/app/qml/ui/RemindersPage.qml	2015-03-01 22:32:41 +0000
+++ src/app/qml/ui/RemindersPage.qml	2015-03-11 10:05:03 +0000
@@ -59,7 +59,6 @@
             delegate: RemindersDelegate {
                 width: remindersListView.width
                 note: notes.note(guid)
-                triggerActionOnMouseRelease: true
 
                 onItemClicked: {
                     root.selectedNote = NotesStore.note(guid);

=== modified file 'src/app/qml/ui/SearchNotesPage.qml'
--- src/app/qml/ui/SearchNotesPage.qml	2015-03-04 23:24:54 +0000
+++ src/app/qml/ui/SearchNotesPage.qml	2015-03-11 10:05:03 +0000
@@ -91,7 +91,6 @@
                 syncError: model.syncError
                 conflicting: model.conflicting
 
-                triggerActionOnMouseRelease: true
                 tags: {
                     var tags = new Array();
                     for (var i = 0; i < model.tagGuids.length; i++) {

=== modified file 'src/app/qml/ui/TagsPage.qml'
--- src/app/qml/ui/TagsPage.qml	2015-03-04 19:48:51 +0000
+++ src/app/qml/ui/TagsPage.qml	2015-03-11 10:05:03 +0000
@@ -83,7 +83,6 @@
             delegate: TagsDelegate {
                 width: parent.width
                 height: units.gu(10)
-                triggerActionOnMouseRelease: true
 
                 onItemClicked: {
                     print("selected tag:", model.guid)

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to     : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to