Andrew Hayzen has proposed merging
lp:~ahayzen/ubuntu-weather-app/reboot-fix-icon-covering-name into
lp:ubuntu-weather-app/reboot.
Commit message:
* Ensure that the height of the image does not cover the text
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/reboot-fix-icon-covering-name/+merge/255213
* Ensure that the height of the image does not cover the text
The height of the image was not being limited, so with the preserve aspect
sometimes the image could cover long names. This image [0] shows before this
patch on the right and after on the left.
0 - https://drive.google.com/file/d/0B3XynHVKfrvMeGcxaDdodklsZzA
--
Your team Ubuntu Weather Developers is requested to review the proposed merge
of lp:~ahayzen/ubuntu-weather-app/reboot-fix-icon-covering-name into
lp:ubuntu-weather-app/reboot.
=== modified file 'app/components/HomeGraphic.qml'
--- app/components/HomeGraphic.qml 2015-02-08 20:56:21 +0000
+++ app/components/HomeGraphic.qml 2015-04-03 20:26:41 +0000
@@ -32,6 +32,7 @@
centerIn: parent
}
fillMode: Image.PreserveAspectFit
+ height: parent.height
width: parent.width
}
}
=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot 2015-04-02 12:19:18 +0000
+++ po/com.ubuntu.weather.pot 2015-04-03 20:26:41 +0000
@@ -8,7 +8,7 @@
msgstr ""
"Project-Id-Version: ubuntu-weather-app\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-03-21 18:07+0100\n"
+"POT-Creation-Date: 2015-04-03 21:18+0100\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <[email protected]>\n"
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
