Review: Needs Fixing Great job.
I have two remarks: 1. You introduced here Paste feature. We are currently not support Pasting in InputTextField. It is readonly, so you could only copy from that. You could check it by long pressing on InputTextField, there is only option "Copy". To introduce Paste feature, we need to enable it both for Phone and for Desktop. Please create Bug report about allow pasting into calculator. And add Ubuntu UX team. They need to decide how user should be notified if wrong data is pasted. Maybe we should just paste without parsing, and trust user (we will be validate during formula push). 2. My idea was to not introduce any more regression with physical keyboard. Could you please create autopilot tests to handle "Enter", "Backspace" and "Deleted" keys? I think you already fixed that. I don't want to break phsyical keyboard support again :-) Maybe it will be good to merge first initial physical keyboard support: https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-keyboard-test ? -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-copy-paste-fix/+merge/264621 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
