Review: Approve
Running through the MP checklist,
* Does the MP add/remove user visible strings? If Yes, has the pot file been
updated?
No user visible strings changed.
* Does the MP change the UI? If Yes, has it been approved by design?
No UI change.
* Did you perform an exploratory manual test run of your code change and any
related functionality?
Yes, tested on N4, #95 image. Works correctly!
* If the MP fixes a bug or implements a feature, are there accompanying unit
and autopilot tests?
Could do with a Unit test. But not a compulsory rule for now. But please do add
unit tests next time for this feature. Quite easy to do.
* Is the clock app trunk buildable and runnable using Qtcreator?
Yes
* Was the debian changelog updated?
Yes
* Was the copyright years updated if necessary?
Yes
LGTM! Approved!
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix/+merge/268069
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
