Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app.
Commit message:
Fixed non-notifyable warning shown when opening the edit alarm page.
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846
Opening the edit alarm page used to result in the following warning shown,
QQmlExpression: Expression
file:///opt/click.ubuntu.com/com.ubuntu.clock/3.5.349/share/qml/alarm/EditAlarmPage.qml:271:17
depends on non-NOTIFYable properties: CustomAlarmSound::alarmSoundDirectory
This was because the property "alarmSoundDirectory" did not notify QML of any
changes since it supposed to be a constant variable. Fixed that minor issue.
--
Your team Ubuntu Clock Developers is requested to review the proposed merge of
lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app.
=== modified file 'backend/modules/Clock/Utility/customalarmsound.h'
--- backend/modules/Clock/Utility/customalarmsound.h 2015-08-22 21:19:54 +0000
+++ backend/modules/Clock/Utility/customalarmsound.h 2015-08-23 10:02:01 +0000
@@ -27,7 +27,8 @@
// READONLY Property to return the custom alarm sound directory path
Q_PROPERTY( QString alarmSoundDirectory
- READ alarmSoundDirectory)
+ READ alarmSoundDirectory
+ CONSTANT)
public:
CustomAlarmSound(QObject *parent = 0);
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
