Michael Zanetti has proposed merging 
lp:~mzanetti/ubuntu-calculator-app/fix-icon-in-layout into 
lp:ubuntu-calculator-app.

Commit message:
fix Icon in layout

The Icon seems a bit picky when it comes to sizing. RowLayout
doesn't care about the size of items, it overwrites them.
The combination of the two a) produces warnings and b) makes
the app freeze sometimes (for example on my desktop).

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/ubuntu-calculator-app/fix-icon-in-layout/+merge/278848
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed 
merge of lp:~mzanetti/ubuntu-calculator-app/fix-icon-in-layout into 
lp:ubuntu-calculator-app.
=== modified file 'app/ui/FavouritePage.qml'
--- app/ui/FavouritePage.qml	2015-11-09 14:18:18 +0000
+++ app/ui/FavouritePage.qml	2015-11-27 16:42:43 +0000
@@ -76,8 +76,8 @@
                 anchors.horizontalCenter: parent.horizontalCenter
                 Icon {
                     id: favouriteIcon
-                    height: parent.height - units.gu(2)
-                    width: height
+                    Layout.preferredHeight: parent.height - units.gu(2)
+                    Layout.preferredWidth: height
 
                     Layout.alignment: Qt.AlignVCenter
 

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to