Review: Needs Fixing Looking good so far, the changes related to the password UI strings should probably go in a separate branch as they are not linked to updating the README.
Also for the branch that has been submitted for weather [0] links to websites are in the format [title](url). And could you add an entry for yourself in the debian/changelog (you should just be able to run $ dch ) 0 - https://code.launchpad.net/~emailgirishrawat/ubuntu-weather-app/markdown-readmes/+merge/280787 Diff comments: > > === modified file 'src/app/qml/AuthenticationDialog.qml' > --- src/app/qml/AuthenticationDialog.qml 2015-07-13 20:25:21 +0000 > +++ src/app/qml/AuthenticationDialog.qml 2015-12-17 22:41:19 +0000 > @@ -24,7 +24,7 @@ > > title: i18n.tr("Authentication required") > > - text: i18n.tr("Enter password:") > + text: i18n.tr("Enter Passcode or Passphrase:") These changes that are modifying the UI strings should probably go into a separate branch. > > signal passwordEntered(string password) > signal dialogCanceled -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/improve_readmes/+merge/280927 Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/improve_readmes into lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
