Review: Needs Fixing
Added some diff comments
Diff comments:
> === modified file 'calendar.qml'
> --- calendar.qml 2016-03-17 17:45:21 +0000
> +++ calendar.qml 2016-03-21 20:47:22 +0000
> @@ -240,11 +253,18 @@
> var requestId = "";
> var callbackFunc = function(id,fetchedItems) {
> if( requestId === id && fetchedItems.length > 0 ) {
> -
> pageStack.push(Qt.resolvedUrl("EventDetails.qml"),{"event":fetchedItems[0],"model":
> eventModel});
> + var event = fetchedItems[0]
> + var currentPage = tabs.selectedTab.page.item
> + console.debug("tabs has showData?" +
> currentPage.showDate)
> + if (currentPage.showDate) {
> + console.debug("Show date:" + event.startDateTime)
Is this log still necessary?
> + currentPage.showDate(event.startDateTime)
> + }
> +
> +
> pageStack.push(Qt.resolvedUrl("EventDetails.qml"),{"event":event,"model":
> eventModel});
> }
> eventModel.onItemsFetched.disconnect( callbackFunc );
> }
> -
> eventModel.onItemsFetched.connect( callbackFunc );
> requestId = eventModel.fetchItems(eventId);
> }
> @@ -575,6 +601,11 @@
> YearView {
> readonly property bool tabSelected: tabs.selectedTabIndex ===
> yearTab.index
>
> + function showDate(date)
> + {
> + efreshCurrentYear(date.getFullYear())
Shouldn't be refreshCurrentYear?
> + }
> +
> reminderValue: mainView.reminderDefaultValue
> model: eventModel.isReady ? eventModel : null
> bootomEdgeEnabled: tabSelected
--
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-1439049/+merge/289198
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
