Hi Maarten, That patch isn't happy; but I'm not sure why yet; I've attached three screen captures: 1) The version with the ubuntu built package - which shows the strange crosshatching from bug 1080674 2) myversion.png - the version with my patch, looks the same as (1) but doesn't crash when I move around my virtual desktops 3) lankhostversion.png (sorry - I typo'd your name !) - the version with your patch applied to a clean 1:1.5.1-0ubuntu2 built on raring.
So erm; that's odd; your version is very broken somehow (and also doesn't update as I type properly I think). (Although it does fix bug 1080674 which I couldn't complain about!) I can't immediately see a problem in your code; maybe the specialised versions need the min/max/x/y swapping if pCir->rotate is set? As for mine being over engineered, obviously there is some personal preference in there; but I was working on the basis if it was needed in all 4 versions then a function was a better bet, and shortClip v MIN/MAX, I tend to prefer functions and anyway the compiler should do what it thinks is best; but as I say that's personal preference. Dave ** Attachment added: "plainversion.png" https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-cirrus/+bug/1043513/+attachment/3460905/+files/plainversion.png ** Changed in: xserver-xorg-video-cirrus (Ubuntu) Status: Incomplete => Triaged -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xserver-xorg-video-cirrus in Ubuntu. https://bugs.launchpad.net/bugs/1043513 Title: Xorg crashed with SIGABRT in memcpy() via cirRefreshArea() under KVM virtual machine To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-cirrus/+bug/1043513/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp