I am going to have a look at this soon. On Wed, 15 Aug 2018 at 23:20, Steve Langasek <steve.langa...@canonical.com> wrote:
> Reviewing ubuntu-drivers-common in the queue, I notice: > > + if (!match) { > + free(match); > > Surely no good can come of this call to free() and it should be omitted? > > The change to start before oem-config.service seems correct but has no > associated bug linked. This looks to me like it should still go through > the SRU verification process because it's unrelated to the other > changes. (Also, it's not 100% obvious that the change is correct: for > example, why does oem-config not provide display-manager.service? Why > are there no interdependencies between oem-config's systemd units and > display-manager.service?) > > The source package as uploaded appears to have a lot of cruft in various > __pycache__ directories. This ought to be cleaned up. > > I'm going to go ahead and reject based on the missing bug reference for > the oem-config.service change. If you think this is wrong, feel free to > ping me on IRC to discuss. > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1778011 > > Title: > SRU: PRIME Power Saving mode draws too much power > > To manage notifications about this bug go to: > https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1778011/+subscriptions > > Launchpad-Notification-Type: bug > Launchpad-Bug: distribution=ubuntu; sourcepackage=gdm3; component=main; > status=Fix Released; importance=High; assignee= > alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; > sourcepackage=nvidia-graphics-drivers-390; component=restricted; status=Fix > Released; importance=High; assignee=alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; sourcepackage=nvidia-prime; > component=main; status=Fix Released; importance=High; assignee= > alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; sourcepackage=nvidia-settings; > component=main; status=Fix Released; importance=High; assignee= > alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; sourcepackage=ubuntu-drivers-common; > component=main; status=Fix Released; importance=High; assignee= > alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; distroseries=bionic; > sourcepackage=gdm3; component=main; status=In Progress; importance=High; > assignee=alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; distroseries=bionic; > sourcepackage=nvidia-graphics-drivers-390; component=restricted; status=In > Progress; importance=High; assignee=alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; distroseries=bionic; > sourcepackage=nvidia-prime; component=main; status=In Progress; > importance=High; assignee=alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; distroseries=bionic; > sourcepackage=nvidia-settings; component=main; status=In Progress; > importance=High; assignee=alberto.mil...@canonical.com; > Launchpad-Bug: distribution=ubuntu; distroseries=bionic; > sourcepackage=ubuntu-drivers-common; component=main; status=In Progress; > importance=High; assignee=alberto.mil...@canonical.com; > Launchpad-Bug-Information-Type: Public > Launchpad-Bug-Private: no > Launchpad-Bug-Security-Vulnerability: no > Launchpad-Bug-Commenters: albertomilone andrebrait cantfind ilvipero > janitor vorlon > Launchpad-Bug-Reporter: Alberto Milone (albertomilone) > Launchpad-Bug-Modifier: Steve Langasek (vorlon) > Launchpad-Message-Rationale: Subscriber > Launchpad-Message-For: albertomilone > -- Alberto Milone -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to nvidia-settings in Ubuntu. https://bugs.launchpad.net/bugs/1778011 Title: SRU: PRIME Power Saving mode draws too much power To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1778011/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp