Ok, performed a review of the NEW packages of fabric-manager-{450,460}.
I'll accept them as is as none of those issues are blocking, but please
fix those before proceeding with the SRUs. The packaging is in overall a
bit on the 'weird' side, but Nvidia pieces can get a bit hairy.

List of minor issues to fix:
 - For fabric-manager-450 the Vcs-Browser field does not exist (looks like the 
450 is not on available on github?). 460 seems to be there though.
 - fabric-manager-450 has .install, .links and .triggers for the 460 packages. 
These need to removed as they're just adding to the confusion.
 - In both packages in debian/rules there's a override_dh_auto_build: that does 
`rm -f lib*.so` - that seems like some leftover that needs cleanup.
 - In debian/rules the BRANCH variable is set to 999 instead of 450 and 460 
respectively. I think this should be kept up to date with the packages that are 
being considered.

Accepting o/

** Also affects: fabric-manager-450 (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: fabric-manager-460 (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu-X,
which is subscribed to nvidia-settings in Ubuntu.
https://bugs.launchpad.net/bugs/1925522

Title:
  Introduce the 465 driver series, fabric-manager, and libnvidia-nscq

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fabric-manager-450/+bug/1925522/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~ubuntu-x-swat
Post to     : ubuntu-x-swat@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-x-swat
More help   : https://help.launchpad.net/ListHelp

Reply via email to