Feedback on the grub2-themes-ubuntustudio package in NEW:
- please review the output of 'lintian -I *changes' on packages. In
particular, in this case:
W: grub2-themes-ubuntustudio source: newer-standards-version 4.3.0 (current is
4.2.1)
(there should be no reason for an out-of-date standards version on a
completely new package)
- why is src/grub2-themes-ubuntu-mate.svg present in the source? this is
obviously not even the right package name.
- debian/copyright includes a lot of redundancy. Files: *, Files: debian/*,
and Files: theme.txt all have the same copyright and license; there is no
reason for separate stanzas vs. a single glob. (I realize this is inherited
from the grub2-themes-ubuntu-mate source package, but that is not the package
I'm currently reviewing in the NEW queue, this one is.)
- I don't know what the debian/post{inst,rm} scripts here are supposed to do -
they are not inherited from the ubuntu-mate theme package, and there is nothing
in the packaging which contains integration that would change the grub theme
selection. I also see that you are calling update-grub2; but this is not the
preferred name for the command, you should be invoking it as 'update-grub'.
Furthermore, since the package depends on grub-common, I don't think there's
any reason for guarding the update-grub call with a 'which' check for the
command.
Since this last point is a potential integration issue, and we are past
FF, I am going to reject the package currently in the NEW queue. Once
this is resolved, I can either sponsor a new upload or rescue the
previous package from the rejected queue as appropriate.
--
You received this bug notification because you are a member of Ubuntu
Studio Bugs, which is subscribed to The Ubuntu Studio Project.
Matching subscriptions: UbuntuStudio Bugs, UbuntuStudioPackages
https://bugs.launchpad.net/bugs/1818373
Title:
[needs-packaging] [FFe] grub2-themes-ubuntustudio
Status in grub2-themes-ubuntustudio:
Fix Committed
Status in Ubuntu Studio:
Fix Committed
Status in ubuntustudio-meta:
Fix Committed
Status in ubuntustudio-meta package in Ubuntu:
Triaged
Bug description:
This is simply a fork of grub2-themes-ubuntu-mate, already in the
repos.
This package is required for many of the newer versions of
ubuntustudio-* packages awaiting upload, on which this is a
dependency.
All code is in the lp:grub2-theme-ubuntustudio git repo.
We have been testing it using our autobuild ppa:
ppa:ubuntustudio-dev/autobuilds
(https://launchpad.net/~ubuntustudiodev/+archive/ubuntu/autobuild)
The package is a grub theme and should not interfere with anything
else. We would appreciate an acknowledgement from the release team
ASAP, as we need sponsorship to get it uploaded.
Additionally, this is a dependency on packages in ubuntustudio-look,
so this must be in the repos for that package to get updated.
To manage notifications about this bug go to:
https://bugs.launchpad.net/grub2-theme-ubuntustudio/+bug/1818373/+subscriptions
--
Mailing list: https://launchpad.net/~ubuntustudio-bugs
Post to : ubuntustudio-bugs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntustudio-bugs
More help : https://help.launchpad.net/ListHelp
