Denys Vlasenko wrote: > On Friday 21 November 2008 06:22, [EMAIL PROTECTED] wrote: >> Author: kraj >> Date: 2008-11-20 21:22:12 -0800 (Thu, 20 Nov 2008) >> New Revision: 24107 >> >> Log: >> Add _res_init.c to resolv_CSRC. > > Please also add a comment why it is necessary. > Hi Denys, I erroneously removed it in the previous commit and Khem fixed it. This part is slightly different in nptl branch because _res is a TLS variable. This is one of the thing that need to be looked better when final merge will occur. So for now, please keep this as the right change. I hope will look at this soon.
Thanks Khem for fix. Carmelo >> --- branches/uClibc-nptl/libc/inet/Makefile.in 2008-11-20 23:41:56 UTC >> (rev 24106) >> +++ branches/uClibc-nptl/libc/inet/Makefile.in 2008-11-21 05:22:12 UTC >> (rev 24107) >> @@ -42,7 +42,7 @@ >> gethostbyaddr_r.c gethostbyname_r.c gethostbyname2_r.c gethostent_r.c \ >> gethostbyaddr.c gethostbyname.c gethostbyname2.c gethostent.c \ >> res_init.c res_query.c res_comp.c ns_name.c \ >> - ethers.c >> + ethers.c _res_state.c > > What does it do? There is no _res_state.c file anywhere I can see. > _res is living in res_init.o: > > #ifdef L_res_init > > /* Protected by __resolv_lock */ > struct __res_state _res; > > /* Will be called under __resolv_lock. */ > static void res_sync_func(void) > { > ... > > > So, if your change is correct, it sure is very non-obvious. > Please add a comment. > -- > vda > _______________________________________________ > uClibc mailing list > uClibc@uclibc.org > http://busybox.net/cgi-bin/mailman/listinfo/uclibc > _______________________________________________ uClibc mailing list uClibc@uclibc.org http://busybox.net/cgi-bin/mailman/listinfo/uclibc