-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Bernhard Reutner-Fischer wrote: > On Tue, Feb 24, 2009 at 01:07:15PM +0100, Carmelo AMOROSO wrote: > >>> Log: >>> - disable libcrypt tests if we have no libcrypt >>> >>> >>> Modified: >>> trunk/uClibc/test/crypt/Makefile >>> >>> >>> Changeset: >>> Modified: trunk/uClibc/test/crypt/Makefile >>> =================================================================== >>> --- trunk/uClibc/test/crypt/Makefile 2009-02-23 10:00:22 UTC (rev >>> 25421) >>> +++ trunk/uClibc/test/crypt/Makefile 2009-02-23 10:50:49 UTC (rev >>> 25422) >>> @@ -1,6 +1,12 @@ >>> # uClibc crypt tests >>> # Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball. >>> >>> +include ../../.config >>> + >>> +ifneq ($(UCLIBC_HAS_CRYPT),y) >>> +TESTS_DISABLED := $(patsubst %.c,%,$(wildcard *.c)) >>> +endif >>> + >>> include ../Test.mak >>> >>> EXTRA_LDFLAGS := -lcrypt >>> >> Hi Bernhard, >> should not be better disabling the whole directory >> in the test/Makefile ? > > Yes, that would be better. >> Anyway it seems that you are confirming that we need to review >> all the test Makefiles that are tryng to test some of the UCLIBC_HAS_xxx >> for selectively build tests. > > Yes. I've touched only those few that cought my eye and cleaned > up the math stuff so we test if we have the desired set of the API really > exported (IIRC i have to push this to trunk too). Any help with the > testsuite would be highly appreciated. >
Bernhard, we are looking in my team at this issue. Indeed we are discovering that several tests are not actually built/executed due to this problem. We'll come soon with a proposal for restructuring testsuite build system (not a huge impact anyway) to solve definitely the issue. I don't like polluting all the Makefile with "include ../../.config". Cheers, Carmelo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iEYEARECAAYFAkmuSwIACgkQoRq/3BrK1s8PRgCgtRRhQgIthn6MZTBogHjpJNlb EJ8AoNlgXw6+pzYN6j8lSz19zggOCzMS =fABb -----END PGP SIGNATURE----- _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
