Just a small tip... figures on the left in patches file listing refers to .c bytesize while those between () on the right to .o bytesize.
Salvo. -----Original Message----- From: Salvatore CRO' [mailto:salvatore....@st.com] Sent: Friday, July 03, 2009 11:07 AM To: carmel...@gmail.com; 'Bernhard Reutner-Fischer' Cc: 'uclibc'; 'Salvatore CRO`' Subject: RE: 100KiB limit is too low I confirm we added argp support, as well as fts within STLinux distribution because it is required by the elfutils libdwfl library. Indeed - FTS, which provides capabilities to represent directory trees in hierarchical manner, is needed by elfutils in - libdwfl library as fs scanning support to report a kernel and all its modules found on disk, for offline use. It can be disabled/enabled within uClibc through UCLIBC_HAS_FTS config option. I issued a unique patch that fit the size limit. - argp, which provides advanced parsing/help/usage/error argp capabilities vs. getopt, is used by elfutils in - libdwfl to create something like a custom parser - all tools (findtextrel, readelf, elflint, addr2line,ar,...) to benefit of parsing functions and so on It can be disabled/enabled within uClibc through UCLIBC_HAS_ARGP config option. Unfortunately original patch ([PATCH] libc: Added argp support) exceeded size limit. This is mainly due to reporting big license header on each file. So I canceled related posting and split the patch into 4 , described below (the new "[PATCH] libc: Added argp support" still exceeded limit a bit - It desn't worth to split over again) : [PATCH] libc: Added argp support : ================================== _Descr_ : Argp source files _Files_ : 1316 libc/argp/argp-ba.c (732) 1254 libc/argp/argp-eexst.c (735) 11685 libc/argp/argp-fmtstream.c (3328) 1708 libc/argp/argp-fs-xinl.c (1648) 55681 libc/argp/argp-help.c (15384) 29284 libc/argp/argp-parse.c (6328) 1479 libc/argp/argp-pvh.c (734) 1287 libc/argp/argp-pv.c (728) 1242 libc/argp/argp-xinl.c (1068) 297 Makefile 721 Makefile.in [PATCH] libc: Added argp headers : ================================== _Descr_ : Strict argp header files _Files_ : 11143 libc/argp/argp-fmtstream.h 25254 include/argp.h [PATCH] libc: Added argp tests : ================================ _Descr_ : Argp test source files _Files_ : 383 test/argp-ex1.c (880) 1688 test/argp-ex2.c (1300) 5418 test/argp-ex3.c (2208) 5392 test/argp-ex4.c (2976) 5589 test/argp-test.c (4716) 434 test/bug-argp1.c (4712) 4428 test/tst-argp1.c (7808) 2485 test/tst-argp2.c (6068) 177 Makefile 286 Makefile.in [PATCH] libc: getopt adj for argp : =================================== _Descr_ : Adjustment needed by argp : - Added long_r/long_only_r support to getopt.c . - getopt_int.h moved to proper common header path. _Files_ : 34165 libc/unistd/getopt.c (3904 ) 0 libc/unistd/getopt_int.h ---> Deleted 5049 libc/sysdeps/linux/common/bits/getopt_int.h ---> Added Hope this help. Cheers, Salvo. -----Original Message----- From: uclibc-boun...@uclibc.org [mailto:uclibc-boun...@uclibc.org] On Behalf Of Carmelo Amoroso Sent: Friday, July 03, 2009 8:17 AM To: Bernhard Reutner-Fischer Cc: uclibc Subject: Re: 100KiB limit is too low Bernhard Reutner-Fischer wrote: > On Thu, Jul 02, 2009 at 04:59:58PM +0200, Carmelo AMOROSO wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Folks, >> we are trying to push some patch we did @ ST to extend uclibc adding >> argp and FTS support. >> My colleague is having some problems sending patches because the >> size threashold is set to 100KiB. >> So he had to split patches in separate chunks, but despite this, a >> patch file (of ~10KiB) is still blocked. > > I just let that 114k patch through but i do not see any other held > patch from Salvatore? He sent firstly all in one patch (includeing headers, tests and libc code), then after having received the message about the limit, he split into several pieces, only the last one of 114k left waiting for the moderator approval. >> Is it possible to enlarge a bit the threshold value ? > > Usually this limit is fine, larger stuff should be split into it's > conceptual parts (or xz'ed or bzip2'ed) > ok, thanks. carmelo > How big is argp support btw? Salvo, may you check and provide information about (also in terms of .o sizes) Anyway it is a configurable feature, so who don't need it, are not impacted by this extra code. e had to add for STLinux distribution becasue we have to support elfutils and libdwf libraries. cheers, carmelo > _______________________________________________ > uClibc mailing list > uClibc@uclibc.org > http://lists.busybox.net/mailman/listinfo/uclibc > _______________________________________________ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc _______________________________________________ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc