> yet another build error for NIOS II (which may very well affect
> other architectures):
>
> ...
> CC arch/nios2nommu/kernel/asm-offsets.s
> arch/nios2nommu/kernel/asm-offsets.c: In function `main':
> arch/nios2nommu/kernel/asm-offsets.c:34: error: structure has no member named
> `thread_info'
> make[2]: *** [arch/nios2nommu/kernel/asm-offsets.s] Error 1
> make[1]: *** [prepare0] Error 2
> make[1]: Leaving directory
> `/home/rpjday/nios2/uclinux/uClinux-dist-cvs/linux-2.6.x'
> make: *** [linux] Error 1
> $
>
> yes, that's a problem since "thread_info" has been renamed to
> "stack", as per this:
>
> http://lkml.org/lkml/2007/4/30/551
>
> which will clearly cause problems in that asm-offsets.c file:
>
> int main(void)
> {
>
> /* offsets into the task struct */
> DEFINE(TASK_STATE, offsetof(struct task_struct, state));
> DEFINE(TASK_FLAGS, offsetof(struct task_struct, flags));
> DEFINE(TASK_PTRACE, offsetof(struct task_struct, ptrace));
> DEFINE(TASK_BLOCKED, offsetof(struct task_struct, blocked));
> DEFINE(TASK_THREAD, offsetof(struct task_struct, thread));
> DEFINE(TASK_THREAD_INFO, offsetof(struct task_struct, thread_info));
> ... uh oh ...
>
> so the obvious question is, what *should* that DEFINE look like? is
> it actually wanting to refer to thread_info itself? or to the stack?
>
> rday
Trying again; without html this time....
Like this:
DEFINE(TASK_THREAD_INFO, offsetof(struct task_struct, stack));
arch/nios2nommu/kernel/process.c also need an update (if you've not already
changed it):
--- trunk/linux-2.6/arch/nios2nommu/kernel/process.c 2006/12/15 15:08:37
153
+++ trunk/linux-2.6/arch/nios2nommu/kernel/process.c 2007/09/19 21:36:44
293
@@ -319,7 +319,7 @@
unsigned long stack_offset, *retp;
stack_offset = THREAD_SIZE - sizeof(struct pt_regs);
- childregs = (struct pt_regs *) ((unsigned long) p->thread_info +
stack_offset);
+ childregs = (struct pt_regs *) ((unsigned long) p->stack +
stack_offset);
p->thread.kregs = childregs;
*childregs = *regs;
- Atle
_______________________________________________
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
