2008/10/20 Mike Frysinger <[EMAIL PROTECTED]>
> On Monday 20 October 2008, Arthur Wong wrote:
> > --- user/e2fsprogs.bak/configure 2008-10-20 17:32:45.000000000 +0800
> > +++ user/e2fsprogs/configure 2008-10-20 17:44:57.000000000 +0800
> > @@ -3076,7 +3076,7 @@ if test "${with_ldopts+set}" = set; then
> > echo "${ECHO_T}LDFLAGS is $withval" >&6
> > LDFLAGS=$withval
> > else
> > - LDFLAGS=
> > + LDFLAGS= -elf2flt
> > fi;
> >
> > # Check whether --with-root-prefix or --without-root-prefix was given.
>
> this is wrong as you've just broken non-FLAT targets ...
Do you mean the package "e2fsprogs" only be used by MMU as default ?
Or if user want to use it in NOMMU, they must have to change it ?
> the configure script has an option to respect LDFLAGS so use it
Does "the configure script" refer to the file e2fsprogs/configure or the
global configure file in uClinux-dist ?
I cann't find the option to respect LDFLAGS in e2fsprogs/configure.
>
>
> > --- user/e2fsprogs.bak/misc/logsave.c 2008-10-20 17:32:45.000000000
> > +++ user/e2fsprogs/misc/logsave.c 2008-10-20 17:39:30.000000000
> > +0800 @@ -113,7 +113,7 @@ static int run_program(char **argv)
> > exit(1);
> > }
> >
> > - pid = fork();
> > + pid = vfork();
> > if (pid < 0) {
> > perror("vfork");
> > exit(1);
>
> this one is OK because it then does execve() ...
>
> > @@ -237,9 +237,9 @@ int main(int argc, char **argv)
> > send_output("----------------\n", 0, send_flag);
> >
> > if (outbuf) {
> > - pid = fork();
> > + pid = vfork();
> > if (pid < 0) {
> > - perror("fork");
> > + perror("vfork");
> > exit(1);
> > }
> > if (pid) {
>
> but this one is wrong because the child will call exit() after writing its
> log
> -mike
>
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
