Hi Mike,
Mike Frysinger wrote:
There are a bunch of things wrong with the oggplay makefile for oggplay
and oggenc ... some highlights:
- CPPFLAGS isnt respected
- -Werror breaks building with gcc-4.3 (maybe real bug, but failures on
warnings shouldnt make it into a release)
- parallel build failure due to incorrect dependency list
Signed-off-by: Mike Frysinger <vap...@gentoo.org>
Applied.
Regards
Greg
user/oggplay/Makefile | 19 ++++++-------------
1 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/user/oggplay/Makefile b/user/oggplay/Makefile
index c6a8d00..05efa61 100644
--- a/user/oggplay/Makefile
+++ b/user/oggplay/Makefile
@@ -3,30 +3,23 @@
DIRS = Tremor
EXEC = oggplay
-OBJS = oggplay.o
-XLIB = Tremor/libvorbisidec.a
+OBJS = oggplay.o Tremor/libvorbisidec.a
EXEC2 = oggenc
OBJS2 = oggenc.o
.PHONY: clean romfs all $(DIRS)
+CFLAGS += -Wall
+CPPFLAGS += -I$(DIRS)
+
all: $(DIRS) $(EXEC) $(EXEC2)
$(EXEC): $(OBJS)
- $(CC) $(LDFLAGS) -o $@ $^ $(XLIB) $(LDLIBS$(LDLIBS_$@))
-
-oggplay.o: oggplay.c
- $(CC) $(CFLAGS) -c $< -o $@ -I$(DIRS) -Wall -Werror
-
$(EXEC2): $(OBJS2)
- $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS$(LDLIBS_$@))
-
-oggenc.o: oggenc.c
- $(CC) $(CFLAGS) -c $< -o $@ -I$(DIRS) -Wall -Werror
-$(DIRS):
- make -C $@
+Tremor/libvorbisidec.a:
+ $(MAKE) -C Tremor
romfs:
$(ROMFSINST) /bin/$(EXEC)
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: g...@snapgear.com
SnapGear, a McAfee Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
