Mike Frysinger wrote: > when posting updates, you should put the "v2" and such inside of the > "[patch]" marker like so: [PATCH v2]. git will remove this > automatically when applying.
Thanks; I didn't know this. > On Thursday 31 December 2009 20:26:45 Jun Sun wrote: > > #define flat_old_ram_flag(flags) (flags) > > -#define flat_reloc_valid(reloc, size) ((reloc) <= (size)) > > +#define flat_reloc_valid(reloc, size) ((reloc) <= (size) + 0x1000) > > +/* [jsun] new gcc 4.x generates ANCHOR symbols in order to reduce the size > > comments go above the thing they're documenting, not below. the "[jsun]" is > also not really useful -- no one who reads this after the fact will have any > idea what "[jsun]" means. I agree with everything Mike said. Put the comment before the #define, and lose the "[jsun]". If someone wants to know who wrote the comment they can use "git blame" and get your full email address. Actually I'd go a bit further: I think it's be tidier to put the comment and #define in their own block, separated by a blank line from the other #defines. I don't see how GCC can make the GOT smaller with relocs pointing _after_ the end of the BSS (middle yes, but after?), but given that it does, the patch looks good to me. -- Jamie _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
