Hi Philippe,

On 20/09/10 21:11, Philippe De Muyter wrote:
Resent, now with checkpath.pl suggested changes, except :

Thats great. I am not concerned about those 3 remaining.
I have applied this patch to the m68knommu git tree.

Regards
Greg



WARNING: please, no space for starting a line,
                                 excluding comments
#75: FILE: arch/m68k/include/asm/gpio.h:39:
+    defined(CONFIG_M527x) || defined(CONFIG_M528x) || \$

WARNING: please, no space for starting a line,
                                 excluding comments
#76: FILE: arch/m68k/include/asm/gpio.h:40:
+    defined(CONFIG_M532x) || defined(CONFIG_M548x)$

WARNING: please write a paragraph that describes the config symbol fully
#355: FILE: arch/m68knommu/Kconfig:176:
+       help

total: 0 errors, 3 warnings, 582 lines checked

0011-m68knommu-add-basic-mmu-less-m548x-support.patch has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Philippe

--

Add a very basic mmu-less support for coldfire m548x family.  This is perhaps
also valid for m547x family.  The port comprises the serial, tick timer and
reboot support.  The gpio part compiles but is empty.  This gives a functional
albeit limited linux for the m548x coldfire family.  This has been tested
on a Freescale M548xEVB Lite board with a M5484 processor and the default
dbug monitor.

Signed-off-by: Philippe De Muyter<p...@macqel.be>
---
  arch/m68k/include/asm/cacheflush_no.h       |    2 +-
  arch/m68k/include/asm/coldfire.h            |    4 +-
  arch/m68k/include/asm/gpio.h                |    7 +-
  arch/m68k/include/asm/m548xgpt.h            |   88 ++++++++++++++++
  arch/m68k/include/asm/m548xsim.h            |   55 ++++++++++
  arch/m68k/include/asm/mcfcache.h            |    2 +-
  arch/m68k/include/asm/mcfsim.h              |    2 +
  arch/m68k/include/asm/mcfslt.h              |   44 ++++++++
  arch/m68k/include/asm/mcfuart.h             |    5 +
  arch/m68knommu/Kconfig                      |    7 +-
  arch/m68knommu/Makefile                     |    3 +
  arch/m68knommu/platform/548x/Makefile       |   18 ++++
  arch/m68knommu/platform/548x/config.c       |  115 +++++++++++++++++++++
  arch/m68knommu/platform/coldfire/Makefile   |    1 +
  arch/m68knommu/platform/coldfire/sltimers.c |  145 +++++++++++++++++++++++++++
  15 files changed, 493 insertions(+), 5 deletions(-)
  create mode 100644 arch/m68k/include/asm/m548xgpt.h
  create mode 100644 arch/m68k/include/asm/m548xsim.h
  create mode 100644 arch/m68k/include/asm/mcfslt.h
  create mode 100644 arch/m68knommu/platform/548x/Makefile
  create mode 100644 arch/m68knommu/platform/548x/config.c
  create mode 100644 arch/m68knommu/platform/coldfire/sltimers.c


--
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     g...@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to