Hi Luis,
On 01/05/12 06:42, Luis Alves wrote:
Here is my second attempt for the 68000 code integration.
What I have done:
Merged all 68000 based cpu's in platform/68000 and deleted 68*328 subdirs.
Modified respective Makefile's to correctly build each target.
Added support for my board/cpu in Kconfig's
Merged all head.S files into one.
Overall this is starting to look really good. I like the common
68000 platform directory. That has worked out well.
Did you send this to the m68k-linux list as well?
I don't see it in the CC list.
This is a big patch on its own though. Do you think there is any
way you can break it up, into logical but smaller pieces?
Something like firstly a patch that reorgs the directories for
current 68x328 targets. Then follow on patches that add your
board support.
Oh, and another suggestion :-)
Did you use git to generate this?
If you use git format-patch with the -B and -M options it will
handle moves and renames a little better, producing much smaller
patches for email list review. It will collapse those pesky
bootlogo.h files in this patch for example. And it also makes it
much easier to see any changes made to moved files that are
otherwise no obvious.
Oh, sorry, another suggestion as well :-)
If you run this patch through the kernels scripts/checkpatch.pl
checker it will list out any formating issues. It would be good to
fix those up as well.
An observation from the patch, the 68000/entry-*.S files all look
quite similar. Is there any way they can be merged into a single
file?
Thanks for doing this, it is looking really nice.
Regards
Greg
In future iterations, more code can/will be merged.
For the 68000 (and my board) the code is working fine. I have a fast and stable
kernel running in the old 68000.
It would be nice if someone could test the 68[xx]328 target code and eventually
fix any bugs.
The exception code for the 68000 is not yet completed (not having the exception
vector on the stack is boring).
I plan to send future updates for the 68000 (and the code for my board drivers,
not included in this patch)
Regards,
Luis Alves
---
arch/m68k/Kconfig.cpu | 2 +-
arch/m68k/Kconfig.machine | 6 +
arch/m68k/Makefile | 6 +-
arch/m68k/include/asm/alce68k.h | 136 ++
arch/m68k/kernel/setup_no.c | 3 +
arch/m68k/platform/68000/Makefile | 26 +
arch/m68k/platform/68000/bootlogo-vz.h | 3204 +++++++++++++++++++++++++++++
arch/m68k/platform/68000/bootlogo.h | 270 +++
arch/m68k/platform/68000/config-alce68k.c | 179 ++
arch/m68k/platform/68000/config-ez.c | 76 +
arch/m68k/platform/68000/config-vz.c | 188 ++
arch/m68k/platform/68000/config.c | 55 +
arch/m68k/platform/68000/entry-68000.S | 463 +++++
arch/m68k/platform/68000/entry-alce68k.S | 453 ++++
arch/m68k/platform/68000/entry.S | 261 +++
arch/m68k/platform/68000/head.S | 310 +++
arch/m68k/platform/68000/ints-alce68k.c | 387 ++++
arch/m68k/platform/68000/ints.c | 186 ++
arch/m68k/platform/68000/romvec.S | 35 +
arch/m68k/platform/68000/timers-alce68k.c | 112 +
arch/m68k/platform/68000/timers.c | 135 ++
arch/m68k/platform/68328/Makefile | 21 -
arch/m68k/platform/68328/bootlogo.h | 270 ---
arch/m68k/platform/68328/config.c | 55 -
arch/m68k/platform/68328/entry.S | 261 ---
arch/m68k/platform/68328/head-de2.S | 128 --
arch/m68k/platform/68328/head-pilot.S | 207 --
arch/m68k/platform/68328/head-ram.S | 141 --
arch/m68k/platform/68328/head-rom.S | 105 -
arch/m68k/platform/68328/ints.c | 186 --
arch/m68k/platform/68328/romvec.S | 35 -
arch/m68k/platform/68328/timers.c | 135 --
arch/m68k/platform/68EZ328/Makefile | 5 -
arch/m68k/platform/68EZ328/config.c | 76 -
arch/m68k/platform/68VZ328/Makefile | 11 -
arch/m68k/platform/68VZ328/bootlogo.h | 3204 -----------------------------
arch/m68k/platform/68VZ328/config.c | 188 --
37 files changed, 6488 insertions(+), 5033 deletions(-)
create mode 100644 arch/m68k/include/asm/alce68k.h
create mode 100644 arch/m68k/platform/68000/Makefile
create mode 100644 arch/m68k/platform/68000/bootlogo-vz.h
create mode 100644 arch/m68k/platform/68000/bootlogo.h
create mode 100644 arch/m68k/platform/68000/config-alce68k.c
create mode 100644 arch/m68k/platform/68000/config-ez.c
create mode 100644 arch/m68k/platform/68000/config-vz.c
create mode 100644 arch/m68k/platform/68000/config.c
create mode 100644 arch/m68k/platform/68000/entry-68000.S
create mode 100644 arch/m68k/platform/68000/entry-alce68k.S
create mode 100644 arch/m68k/platform/68000/entry.S
create mode 100644 arch/m68k/platform/68000/head.S
create mode 100644 arch/m68k/platform/68000/ints-alce68k.c
create mode 100644 arch/m68k/platform/68000/ints.c
create mode 100644 arch/m68k/platform/68000/romvec.S
create mode 100644 arch/m68k/platform/68000/timers-alce68k.c
create mode 100644 arch/m68k/platform/68000/timers.c
delete mode 100644 arch/m68k/platform/68328/Makefile
delete mode 100644 arch/m68k/platform/68328/bootlogo.h
delete mode 100644 arch/m68k/platform/68328/config.c
delete mode 100644 arch/m68k/platform/68328/entry.S
delete mode 100644 arch/m68k/platform/68328/head-de2.S
delete mode 100644 arch/m68k/platform/68328/head-pilot.S
delete mode 100644 arch/m68k/platform/68328/head-ram.S
delete mode 100644 arch/m68k/platform/68328/head-rom.S
delete mode 100644 arch/m68k/platform/68328/ints.c
delete mode 100644 arch/m68k/platform/68328/romvec.S
delete mode 100644 arch/m68k/platform/68328/timers.c
delete mode 100644 arch/m68k/platform/68EZ328/Makefile
delete mode 100644 arch/m68k/platform/68EZ328/config.c
delete mode 100644 arch/m68k/platform/68VZ328/Makefile
delete mode 100644 arch/m68k/platform/68VZ328/bootlogo.h
delete mode 100644 arch/m68k/platform/68VZ328/config.c
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: g...@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
